Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 1471783002: Provider API for UpdatableConfig (Closed)

Created:
5 years, 1 month ago by sdefresne
Modified:
5 years, 1 month ago
Reviewers:
droger
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Provider API for UpdatableConfig. BUG=475442 Committed: https://crrev.com/e102ab8c09f75131bd87d86830078219a0f94b0b Cr-Commit-Position: refs/heads/master@{#361131}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove duplicate implementation of GetUpdatableResourceProvider() method #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M ios/public/test/test_chrome_browser_provider.h View 3 chunks +3 lines, -0 lines 0 comments Download
M ios/public/test/test_chrome_browser_provider.mm View 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
sdefresne
Please take a look.
5 years, 1 month ago (2015-11-23 15:52:15 UTC) #2
droger
https://codereview.chromium.org/1471783002/diff/1/ios/public/provider/chrome/browser/chrome_browser_provider.cc File ios/public/provider/chrome/browser/chrome_browser_provider.cc (right): https://codereview.chromium.org/1471783002/diff/1/ios/public/provider/chrome/browser/chrome_browser_provider.cc#newcode66 ios/public/provider/chrome/browser/chrome_browser_provider.cc:66: } This function is duplicated above.
5 years, 1 month ago (2015-11-23 16:00:46 UTC) #3
sdefresne
https://codereview.chromium.org/1471783002/diff/1/ios/public/provider/chrome/browser/chrome_browser_provider.cc File ios/public/provider/chrome/browser/chrome_browser_provider.cc (right): https://codereview.chromium.org/1471783002/diff/1/ios/public/provider/chrome/browser/chrome_browser_provider.cc#newcode66 ios/public/provider/chrome/browser/chrome_browser_provider.cc:66: } On 2015/11/23 at 16:00:46, droger wrote: > This ...
5 years, 1 month ago (2015-11-23 16:52:38 UTC) #4
droger
lgtm
5 years, 1 month ago (2015-11-23 16:55:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1471783002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1471783002/20001
5 years, 1 month ago (2015-11-23 17:21:37 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-23 17:27:48 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-11-23 17:28:52 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e102ab8c09f75131bd87d86830078219a0f94b0b
Cr-Commit-Position: refs/heads/master@{#361131}

Powered by Google App Engine
This is Rietveld 408576698