update-w3c-deps import using blink f0408c3aa2c878571a05e341363c5a0319959733:

update-w3c-deps import using blink 5636fefe1d743cc2a8af65f78eaeed4b98f0012b:

imported csswg-test@7cfea4d5ba33861b0b1a6839c27090bc504a169f
imported web-platform-tests@5f8361dcef1a7c80b61d6319f7b510fa431f9a47

R=dpranke@chromium.org,kojii@chromium.org

Committed: https://crrev.com/95aa1770a52712c3d9ede62cf64024985e1c5227
Cr-Commit-Position: refs/heads/master@{#361653}

[philipj_slow, 2015-11-24 10:31:23]

The CQ bit was checked by philipj@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2015-11-24 10:34:22]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1471763006/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1471763006/1

[commit-bot: I haz the power, 2015-11-24 11:20:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-24 11:20:08]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[philipj_slow, 2015-11-24 14:01:01]

On 2015/11/24 11:20:08, commit-bot: I haz the power wrote:
> Dry run: Try jobs failed on following builders:
>   win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

This didn't go too well. What's the general drill here, investigate each
individual failure or just blindly exclude new failing tests to unblock the
import process?

[Dirk Pranke, 2015-11-24 18:05:07]

Description was changed from

==========
update-w3c-deps import using blink f0408c3aa2c878571a05e341363c5a0319959733:

imported csswg-test@98205c1537fc05795a3f63ddd4556148b5fde28c
imported web-platform-tests@8f35fba1b5e75dd87c9b973dcf32408d5efb553f

R=dpranke@chromium.org
==========

to

==========
update-w3c-deps import using blink f0408c3aa2c878571a05e341363c5a0319959733:

imported csswg-test@98205c1537fc05795a3f63ddd4556148b5fde28c
imported web-platform-tests@8f35fba1b5e75dd87c9b973dcf32408d5efb553f

R=dpranke@chromium.org
==========

[Dirk Pranke, 2015-11-24 18:05:07]

dpranke@chromium.org changed reviewers:
+ kojii@chromium.org

[Dirk Pranke, 2015-11-24 18:05:16]

On 2015/11/24 14:01:01, philipj wrote:
> On 2015/11/24 11:20:08, commit-bot: I haz the power wrote:
> > Dry run: Try jobs failed on following builders:
> >   win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
> >
>
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
> 
> This didn't go too well. What's the general drill here, investigate each
> individual failure or just blindly exclude new failing tests to unblock the
> import process?

I don't think we have a standardized drill here, unfortunately.

kojii@chromium.org has been working on importing the writing modes tests
(see crbug.com/492664).

I'd probably at least spend a little time trying to figure out what the
regressions
are due to, skip the new tests, and file bugs for the existing tests, but you
might
ping kojii@ and see what he'd prefer.

[kojii, 2015-11-25 01:32:02]

On 2015/11/24 18:05:16, Dirk Pranke wrote:
> On 2015/11/24 14:01:01, philipj wrote:
> > On 2015/11/24 11:20:08, commit-bot: I haz the power wrote:
> > > Dry run: Try jobs failed on following builders:
> > >   win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
> > >
> >
>
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
> > 
> > This didn't go too well. What's the general drill here, investigate each
> > individual failure or just blindly exclude new failing tests to unblock the
> > import process?
> 
> I don't think we have a standardized drill here, unfortunately.
> 
> mailto:kojii@chromium.org has been working on importing the writing modes
tests
> (see crbug.com/492664).
> 
> I'd probably at least spend a little time trying to figure out what the
> regressions
> are due to, skip the new tests, and file bugs for the existing tests, but you
> might
> ping kojii@ and see what he'd prefer.

Sorry for a late reply. The 'writing-mode: sideways-lr' and 'sideways-rl' are
two values we do not plan to support atm. Please add them to
W3CImportExpectations as [Skip]. There a section for it already.

I'm asking test engineers to make clear from file name since these values are
"at risk", but not getting enough consensus yet.

[kojii, 2015-11-25 04:02:32]

Note that the w3c test importer imports JS and ref tests only, skips manual
tests. These are ref tests, so expected.txt/png do not work. We need to either
skip or fail.

[philipj_slow, 2015-11-25 12:45:19]

Description was changed from

==========
update-w3c-deps import using blink f0408c3aa2c878571a05e341363c5a0319959733:

imported csswg-test@98205c1537fc05795a3f63ddd4556148b5fde28c
imported web-platform-tests@8f35fba1b5e75dd87c9b973dcf32408d5efb553f

R=dpranke@chromium.org
==========

to

==========
update-w3c-deps import using blink 5636fefe1d743cc2a8af65f78eaeed4b98f0012b:

imported csswg-test@7cfea4d5ba33861b0b1a6839c27090bc504a169f
imported web-platform-tests@5f8361dcef1a7c80b61d6319f7b510fa431f9a47

R=dpranke@chromium.org,kojii@chromium.org
==========

[philipj_slow, 2015-11-25 12:46:48]

I've updated W3CImportExpectations and made a new import, PTAL.

[kojii, 2015-11-25 12:56:56]

lgtm

[philipj_slow, 2015-11-25 14:05:13]

The CQ bit was checked by philipj@opera.com

[commit-bot: I haz the power, 2015-11-25 14:05:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1471763006/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1471763006/20001

[commit-bot: I haz the power, 2015-11-25 14:53:50]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-11-25 14:54:59]

Patchset 2 (id:??) landed as
https://crrev.com/95aa1770a52712c3d9ede62cf64024985e1c5227
Cr-Commit-Position: refs/heads/master@{#361653}