content/test/data/background_sync/service_worker.js - Issue 1471763003: [BackgroundSync] Only allow SyncManager.register to occur from main frame

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/test/data/background_sync/service_worker.js

Issue 1471763003: [BackgroundSync] Only allow SyncManager.register to occur from main frame (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@split

Patch Set: Address comments from PS6 Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/test/data/background_sync/register_sync_sw.js ('k') | third_party/WebKit/LayoutTests/http/tests/background_sync/oneshot.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/test/data/background_sync/service_worker.js

diff --git a/content/test/data/background_sync/service_worker.js b/content/test/data/background_sync/service_worker.js

index e04bf30d65d0b53b295bd7fae8850cb105400249..140759d208b6d868567e83b3475012faf9aa5121 100644

--- a/content/test/data/background_sync/service_worker.js

+++ b/content/test/data/background_sync/service_worker.js

@@ -105,7 +105,7 @@ this.onsync = function(event) {

};

function sendMessageToClients(type, data) {

- clients.matchAll().then(function(clients) {

+ clients.matchAll({ includeUncontrolled: true }).then(function(clients) {

clients.forEach(function(client) {

client.postMessage({type, data});

});