Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1471763002: Fix stroking of zero length paths with end caps on NVPR (Closed)

Created:
5 years, 1 month ago by Kimmo Kinnunen
Modified:
5 years ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix stroking of zero length paths with end caps on NVPR Fix stroking of zero length paths with end caps on NVPR. In case of such paths, stroke them using Skia and just fill the path with NVPR. BUG=skia:4427 Committed: https://skia.googlesource.com/skia/+/1e2913e7cb8c8122151cabd0aa6c77011253e95b

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+236 lines, -127 lines) Patch
M src/gpu/gl/GrGLPath.h View 1 1 chunk +10 lines, -4 lines 0 comments Download
M src/gpu/gl/GrGLPath.cpp View 1 2 1 chunk +191 lines, -101 lines 0 comments Download
M src/gpu/gl/GrGLPathRange.cpp View 1 2 chunks +35 lines, -22 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Kimmo Kinnunen
5 years ago (2015-11-24 10:11:06 UTC) #2
Kimmo Kinnunen
5 years ago (2015-11-25 05:07:33 UTC) #4
bsalomon
lgtm
5 years ago (2015-11-30 15:41:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1471763002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1471763002/40001
5 years ago (2015-12-01 06:58:23 UTC) #7
commit-bot: I haz the power
5 years ago (2015-12-01 12:35:40 UTC) #9
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/1e2913e7cb8c8122151cabd0aa6c77011253e95b

Powered by Google App Engine
This is Rietveld 408576698