Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Issue 1471753004: Take span len into account when determining whether gradient is vertical (Closed)

Created:
5 years, 1 month ago by f(malita)
Modified:
5 years, 1 month ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Take span len into account when determining whether gradient is vertical R=reed@google.com Committed: https://skia.googlesource.com/skia/+/2b46913c99319de9567390e8a543057be0c162e3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/effects/gradients/SkLinearGradient.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1471753004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1471753004/1
5 years, 1 month ago (2015-11-23 15:25:05 UTC) #2
f(malita)
5 years, 1 month ago (2015-11-23 15:25:35 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-23 15:37:14 UTC) #5
reed1
Nice idea. Does this fix a particular test, or speed something up? lgtm
5 years, 1 month ago (2015-11-23 16:15:03 UTC) #6
f(malita)
On 2015/11/23 16:15:03, reed1 wrote: > Nice idea. Does this fix a particular test, or ...
5 years, 1 month ago (2015-11-23 16:29:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1471753004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1471753004/1
5 years, 1 month ago (2015-11-23 16:29:35 UTC) #9
commit-bot: I haz the power
5 years, 1 month ago (2015-11-23 16:30:26 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/2b46913c99319de9567390e8a543057be0c162e3

Powered by Google App Engine
This is Rietveld 408576698