Issue 1471753002: Do not consider url query when setting application arguments.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1471753002: Do not consider url query when setting application arguments. (Closed)

Created:
5 years, 1 month ago by qsr

Modified:
5 years, 1 month ago

Reviewers:
ppi

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -3 lines)			Patch
	M	shell/application_manager/application_manager.cc	View	1 2	2 chunks	+8 lines, -3 lines	0 comments	Download
	M	shell/application_manager/application_manager_unittest.cc	View	1 2	1 chunk	+22 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

ppi

lgtm for the fix, I'd suggest split out the command_line_util change into a separate cl ...

5 years, 1 month ago (2015-11-23 14:23:31 UTC) #2

qsr

5 years, 1 month ago (2015-11-23 14:34:09 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
aec7ef80a272939a24d0e681cc98e9dcfac4e736 (presubmit successful).