[turbofan] Further simplify representation inference for NumberTo(U)int32.

src/compiler/simplified-lowering.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler/simplified-lowering.h"
 
 #include <limits>
 
 #include "src/base/bits.h"
 #include "src/code-factory.h"
@@ skipping 112 matching lines @@
   // This should only be used by the Enqueue method.
   MachineTypeUnion machine_type() const { return type_; }
 
  private:
   explicit UseInfo(MachineTypeUnion type) : type_(type) {}
 
   MachineTypeUnion type_;
 };
 
 
-UseInfo UseInfoFromRepresentation(MachineTypeUnion rep) {
+UseInfo UseInfoFromMachineType(MachineType type) {
+  MachineTypeUnion rep = RepresentationOf(type);
   DCHECK((rep & kTypeMask) == 0);
   if (rep & kRepTagged) return UseInfo::AnyTagged();
   if (rep & kRepFloat64) {
     DCHECK((rep & kRepWord64) == 0);
     return UseInfo::Float64();
   }
   if (rep & kRepFloat32) {
     if (rep == kRepFloat32) return UseInfo::Float32();
     return UseInfo::AnyTagged();
   }
   if (rep & kRepWord64) {
     return UseInfo::TruncatingWord64();
   }
   if (rep & (kRepWord32 | kRepWord16 | kRepWord8)) {
     CHECK(!(rep & kRepBit));
     return UseInfo::TruncatingWord32();
   }
   DCHECK(rep & kRepBit);
   return UseInfo::Bool();
 }
 
 
-UseInfo UseInfoFromMachineType(MachineType type) {
-  return UseInfoFromRepresentation(RepresentationOf(type));
-}
-
-
 UseInfo UseInfoForBasePointer(const FieldAccess& access) {
   return access.tag() != 0 ? UseInfo::AnyTagged() : UseInfo::PointerInt();
 }
 
 
 UseInfo UseInfoForBasePointer(const ElementAccess& access) {
   return access.tag() != 0 ? UseInfo::AnyTagged() : UseInfo::PointerInt();
 }
 
 }  // namespace
@@ skipping 649 matching lines @@
         if (lower()) lowering->DoShift(node, lowering->machine()->Word32Sar());
         break;
       }
       case IrOpcode::kNumberShiftRightLogical: {
         VisitBinop(node, UseInfo::TruncatingWord32(),
                    UseInfo::TruncatingWord32(), kMachUint32);
         if (lower()) lowering->DoShift(node, lowering->machine()->Word32Shr());
         break;
       }
       case IrOpcode::kNumberToInt32: {
-        MachineTypeUnion use_rep = use & kRepMask;
-        Node* input = node->InputAt(0);
-        Type* in_upper = NodeProperties::GetType(input);
-        if (in_upper->Is(Type::Signed32())) {
-          // If the input has type int32, pass through representation.
-          VisitUnop(node, UseInfoFromRepresentation(use_rep),
-                    kTypeInt32 | use_rep);
-          if (lower()) DeferReplacement(node, node->InputAt(0));
-        } else {
-          // Just change representation if necessary.
-          VisitUnop(node, UseInfo::TruncatingWord32(), kMachInt32);
-          if (lower()) DeferReplacement(node, node->InputAt(0));
-        }
+        // Just change representation if necessary.
+        VisitUnop(node, UseInfo::TruncatingWord32(), kMachInt32);
+        if (lower()) DeferReplacement(node, node->InputAt(0));
         break;
       }
       case IrOpcode::kNumberToUint32: {
-        MachineTypeUnion use_rep = use & kRepMask;
-        Node* input = node->InputAt(0);
-        Type* in_upper = NodeProperties::GetType(input);
-        if (in_upper->Is(Type::Unsigned32())) {
-          // If the input has type uint32, pass through representation.
-          VisitUnop(node, UseInfoFromRepresentation(use_rep),
-                    kTypeUint32 | use_rep);
-          if (lower()) DeferReplacement(node, node->InputAt(0));
-        } else {
-          // Just change representation if necessary.
-          VisitUnop(node, UseInfo::TruncatingWord32(), kMachUint32);
-          if (lower()) DeferReplacement(node, node->InputAt(0));
-        }
+        // Just change representation if necessary.
+        VisitUnop(node, UseInfo::TruncatingWord32(), kMachUint32);
+        if (lower()) DeferReplacement(node, node->InputAt(0));
         break;
       }
       case IrOpcode::kNumberIsHoleNaN: {
         VisitUnop(node, UseInfo::Float64(), kMachBool);
         if (lower()) {
           // NumberIsHoleNaN(x) => Word32Equal(Float64ExtractLowWord32(x),
           //                                   #HoleNaNLower32)
           node->ReplaceInput(0,
                              jsgraph_->graph()->NewNode(
                                  lowering->machine()->Float64ExtractLowWord32(),
@@ skipping 790 matching lines @@
   ReplaceEffectUses(node, comparison);
   node->ReplaceInput(0, comparison);
   node->ReplaceInput(1, jsgraph()->SmiConstant(EQUAL));
   node->TrimInputCount(2);
   NodeProperties::ChangeOp(node, machine()->IntLessThanOrEqual());
 }
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8