Optimize ClearNonLiveReferences: collect dependent code only from maps that are embedded in optimize

Optimize ClearNonLiveReferences: collect dependent code only from maps that are embedded in optimize code.

BUG=chromium:554488
LOG=NO

Committed: https://crrev.com/e777784fb49e193cf09cda8140190c0f2dc52dca
Cr-Commit-Position: refs/heads/master@{#32218}

[ulan, 2015-11-23 10:47:20]

The CQ bit was checked by ulan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-23 10:47:26]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1471703002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1471703002/20001

[ulan, 2015-11-23 12:15:51]

Description was changed from

==========
Optimize ClearNonLiveReferences.

Collect dependent code only from maps that are embedded in optimize code.

BUG=chromium:554488
LOG=NO
==========

to

==========
Optimize ClearNonLiveReferences: Collect dependent code only from maps that are
embedded in optimize code.

BUG=chromium:554488
LOG=NO
==========

[ulan, 2015-11-23 12:16:02]

Description was changed from

==========
Optimize ClearNonLiveReferences: Collect dependent code only from maps that are
embedded in optimize code.

BUG=chromium:554488
LOG=NO
==========

to

==========
Optimize ClearNonLiveReferences: collect dependent code only from maps that are
embedded in optimize code.

BUG=chromium:554488
LOG=NO
==========

[ulan, 2015-11-23 12:16:13]

ulan@chromium.org changed reviewers:
+ hpayer@chromium.org

[ulan, 2015-11-23 12:16:14]

PTAL

https://codereview.chromium.org/1471703002/diff/20001/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (left):

https://codereview.chromium.org/1471703002/diff/20001/src/heap/mark-compact.c...
src/heap/mark-compact.cc:1825: if (heap()->ShouldReduceMemory() ||
heap()->ShouldAbortIncrementalMarking() ||
Early return was a bug. We still need to compact the array to get rid of cleared
cells.

https://codereview.chromium.org/1471703002/diff/20001/src/heap/mark-compact.c...
src/heap/mark-compact.cc:2212: have_code_to_deoptimize_ |=
Moving this code out is the main change.

[Hannes Payer (out of office), 2015-11-24 09:35:37]

LGTM

https://codereview.chromium.org/1471703002/diff/60001/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (right):

https://codereview.chromium.org/1471703002/diff/60001/src/heap/mark-compact.c...
src/heap/mark-compact.cc:352: // This should be done before processing weak
cells because it checks
Let's add here a special category: ProcessWeakReferences
On a high level, this method should:
Mark
Handle weak references
Sweep
I would not like to pollute this method with two many details. We can clean-up
the rest of the method in that CL as well, or in a different CL.

https://codereview.chromium.org/1471703002/diff/60001/src/heap/mark-compact.c...
src/heap/mark-compact.cc:1905: DependentCode*
MarkCompactCollector::DependentCodeListFromNonLiveMaps() {
Timer scope.

https://codereview.chromium.org/1471703002/diff/60001/src/heap/mark-compact.c...
src/heap/mark-compact.cc:2277: void
MarkCompactCollector::MarkDependentCodeListForDeoptimization(
Timer scope.

[ulan, 2015-11-24 12:00:08]

https://codereview.chromium.org/1471703002/diff/60001/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (right):

https://codereview.chromium.org/1471703002/diff/60001/src/heap/mark-compact.c...
src/heap/mark-compact.cc:352: // This should be done before processing weak
cells because it checks
On 2015/11/24 09:35:36, Hannes Payer wrote:
> Let's add here a special category: ProcessWeakReferences
> On a high level, this method should:
> Mark
> Handle weak references
> Sweep
> I would not like to pollute this method with two many details. We can clean-up
> the rest of the method in that CL as well, or in a different CL.

Done.

https://codereview.chromium.org/1471703002/diff/60001/src/heap/mark-compact.c...
src/heap/mark-compact.cc:1905: DependentCode*
MarkCompactCollector::DependentCodeListFromNonLiveMaps() {
On 2015/11/24 09:35:37, Hannes Payer wrote:
> Timer scope.

Done.

https://codereview.chromium.org/1471703002/diff/60001/src/heap/mark-compact.c...
src/heap/mark-compact.cc:2277: void
MarkCompactCollector::MarkDependentCodeListForDeoptimization(
On 2015/11/24 09:35:36, Hannes Payer wrote:
> Timer scope.

Done.

[ulan, 2015-11-24 14:35:27]

The CQ bit was checked by ulan@chromium.org

[ulan, 2015-11-24 14:35:27]

The patchset sent to the CQ was uploaded after l-g-t-m from hpayer@chromium.org
Link to the patchset: https://codereview.chromium.org/1471703002/#ps160001
(title: " ")

[commit-bot: I haz the power, 2015-11-24 14:35:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1471703002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1471703002/160001

[commit-bot: I haz the power, 2015-11-24 15:35:31]

Committed patchset #9 (id:160001)

[commit-bot: I haz the power, 2015-11-24 15:35:52]

Patchset 9 (id:??) landed as
https://crrev.com/e777784fb49e193cf09cda8140190c0f2dc52dca
Cr-Commit-Position: refs/heads/master@{#32218}