Issue 1471693003: Revert of DevTools: Add dark theme hidden experiment

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1471693003: Revert of DevTools: Add dark theme hidden experiment (Closed)

Created:
5 years, 1 month ago by pfeldman

Modified:
5 years, 1 month ago

Reviewers:
paulirish

CC:
apavlov+blink_chromium.org, blink-reviews, blink-reviews-style_chromium.org, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, samccone, sergeyv+blink_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Revert of DevTools: Add dark theme hidden experiment (patchset #2 id:20001 of https://codereview.chromium.org/1458223005/ ) Reason for revert: Since the theme does not work and can't be used, this should really be behind 10 shifts. Original issue's description: > DevTools: Add dark theme hidden experiment > > BUG=559524 > > Committed: https://crrev.com/a7d0f43f83b514a46ec3850aab3160412cdd8a53 > Cr-Commit-Position: refs/heads/master@{#361015} TBR=paulirish@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=559524 Committed: https://crrev.com/317a5813817bfe6c5e59cfe5eec89789031c0b27 Cr-Commit-Position: refs/heads/master@{#361174}

Patch Set 1 #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -12 lines)			Patch
	M	third_party/WebKit/Source/devtools/front_end/inspectorStyle.css	View		2 chunks	+0 lines, -8 lines	0 comments	Download
	M	third_party/WebKit/Source/devtools/front_end/main/Main.js	View		2 chunks	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

pfeldman

Created Revert of DevTools: Add dark theme hidden experiment

5 years, 1 month ago (2015-11-23 20:27:07 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1471693003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1471693003/1

5 years, 1 month ago (2015-11-23 20:27:57 UTC) #2

commit-bot: I haz the power

5 years, 1 month ago (2015-11-23 20:33:00 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/317a5813817bfe6c5e59cfe5eec89789031c0b27
Cr-Commit-Position: refs/heads/master@{#361174}

Expand Messages | Collapse Messages