Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Issue 1471673003: [Telemetry] Set the number of processes to use for telemetry_unittests on win platform to be 1 (Closed)

Created:
5 years ago by nednguyen
Modified:
5 years ago
Reviewers:
M-A Ruel
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Set the number of processes to use for telemetry_unittests on win platform to be 1 to temporarily fix the race condition on win bot. BUG=559154 NOTRY=true Committed: https://crrev.com/b3b8c6ebf55d4bb55d728456dfc675115da45dce Cr-Commit-Position: refs/heads/master@{#361170}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Group all the common files to a same condition #

Total comments: 4

Patch Set 3 : Add missing comma #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -1 line) Patch
M chrome/telemetry_unittests.isolate View 1 2 1 chunk +20 lines, -1 line 0 comments Download

Messages

Total messages: 28 (11 generated)
nednguyen
5 years ago (2015-11-23 16:06:50 UTC) #3
M-A Ruel
https://codereview.chromium.org/1471673003/diff/1/chrome/telemetry_unittests.isolate File chrome/telemetry_unittests.isolate (right): https://codereview.chromium.org/1471673003/diff/1/chrome/telemetry_unittests.isolate#newcode29 chrome/telemetry_unittests.isolate:29: 'files': [ Please keep common variables grouped, e.g. keep ...
5 years ago (2015-11-23 16:09:05 UTC) #4
nednguyen
https://codereview.chromium.org/1471673003/diff/1/chrome/telemetry_unittests.isolate File chrome/telemetry_unittests.isolate (right): https://codereview.chromium.org/1471673003/diff/1/chrome/telemetry_unittests.isolate#newcode29 chrome/telemetry_unittests.isolate:29: 'files': [ On 2015/11/23 16:09:05, M-A Ruel wrote: > ...
5 years ago (2015-11-23 16:11:52 UTC) #5
M-A Ruel
lgtm, thanks
5 years ago (2015-11-23 16:12:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1471673003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1471673003/20001
5 years ago (2015-11-23 16:15:07 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/144613)
5 years ago (2015-11-23 16:26:34 UTC) #10
M-A Ruel
https://codereview.chromium.org/1471673003/diff/20001/chrome/telemetry_unittests.isolate File chrome/telemetry_unittests.isolate (right): https://codereview.chromium.org/1471673003/diff/20001/chrome/telemetry_unittests.isolate#newcode27 chrome/telemetry_unittests.isolate:27: '..' add comma here, so this error won't be ...
5 years ago (2015-11-23 16:28:40 UTC) #11
nednguyen
Thanks for following up with the errors! https://codereview.chromium.org/1471673003/diff/20001/chrome/telemetry_unittests.isolate File chrome/telemetry_unittests.isolate (right): https://codereview.chromium.org/1471673003/diff/20001/chrome/telemetry_unittests.isolate#newcode27 chrome/telemetry_unittests.isolate:27: '..' On ...
5 years ago (2015-11-23 16:29:51 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1471673003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1471673003/40001
5 years ago (2015-11-23 16:30:36 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/132780)
5 years ago (2015-11-23 17:54:50 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1471673003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1471673003/40001
5 years ago (2015-11-23 18:05:49 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/132870)
5 years ago (2015-11-23 19:28:50 UTC) #21
nednguyen
On 2015/11/23 19:28:50, commit-bot: I haz the power wrote: > Try jobs failed on following ...
5 years ago (2015-11-23 19:29:45 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1471673003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1471673003/40001
5 years ago (2015-11-23 19:35:25 UTC) #25
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-11-23 20:20:57 UTC) #26
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/b3b8c6ebf55d4bb55d728456dfc675115da45dce Cr-Commit-Position: refs/heads/master@{#361170}
5 years ago (2015-11-23 20:21:49 UTC) #27
nednguyen
5 years ago (2015-12-04 16:51:27 UTC) #28
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1498093002/ by nednguyen@google.com.

The reason for reverting is: crbug.com/559154 should be fixed.

Powered by Google App Engine
This is Rietveld 408576698