|
|
Chromium Code Reviews
DescriptionSet the number of processes to use for telemetry_unittests on
win platform to be 1 to temporarily fix the race condition on
win bot.
BUG=559154
NOTRY=true
Committed: https://crrev.com/b3b8c6ebf55d4bb55d728456dfc675115da45dce
Cr-Commit-Position: refs/heads/master@{#361170}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Group all the common files to a same condition #
Total comments: 4
Patch Set 3 : Add missing comma #Messages
Total messages: 28 (11 generated)
Description was changed from ========== Set the number of processes to use for telemetry_unittests on win platform to be 1 BUG=559154 ========== to ========== Set the number of processes to use for telemetry_unittests on win platform to be 1 to temporarily fix the race condition on win bot. BUG=559154 ==========
nednguyen@google.com changed reviewers: + maruel@chromium.org
https://codereview.chromium.org/1471673003/diff/1/chrome/telemetry_unittests.... File chrome/telemetry_unittests.isolate (right): https://codereview.chromium.org/1471673003/diff/1/chrome/telemetry_unittests.... chrome/telemetry_unittests.isolate:29: 'files': [ Please keep common variables grouped, e.g. keep a section ['OS=="mac" or OS=="win"', { that holds the common files.
https://codereview.chromium.org/1471673003/diff/1/chrome/telemetry_unittests.... File chrome/telemetry_unittests.isolate (right): https://codereview.chromium.org/1471673003/diff/1/chrome/telemetry_unittests.... chrome/telemetry_unittests.isolate:29: 'files': [ On 2015/11/23 16:09:05, M-A Ruel wrote: > Please keep common variables grouped, e.g. keep a section > ['OS=="mac" or OS=="win"', { > > that holds the common files. Done.
lgtm, thanks
The CQ bit was checked by nednguyen@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1471673003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1471673003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
https://codereview.chromium.org/1471673003/diff/20001/chrome/telemetry_unitte... File chrome/telemetry_unittests.isolate (right): https://codereview.chromium.org/1471673003/diff/20001/chrome/telemetry_unitte... chrome/telemetry_unittests.isolate:27: '..' add comma here, so this error won't be repeated. https://codereview.chromium.org/1471673003/diff/20001/chrome/telemetry_unitte... chrome/telemetry_unittests.isolate:38: '..' missing comma
Thanks for following up with the errors! https://codereview.chromium.org/1471673003/diff/20001/chrome/telemetry_unitte... File chrome/telemetry_unittests.isolate (right): https://codereview.chromium.org/1471673003/diff/20001/chrome/telemetry_unitte... chrome/telemetry_unittests.isolate:27: '..' On 2015/11/23 16:28:40, M-A Ruel wrote: > add comma here, so this error won't be repeated. Done. https://codereview.chromium.org/1471673003/diff/20001/chrome/telemetry_unitte... chrome/telemetry_unittests.isolate:38: '..' On 2015/11/23 16:28:40, M-A Ruel wrote: > missing comma Done.
The CQ bit was checked by nednguyen@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from maruel@chromium.org Link to the patchset: https://codereview.chromium.org/1471673003/#ps40001 (title: "Add missing comma")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1471673003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1471673003/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by nednguyen@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1471673003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1471673003/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Description was changed from ========== Set the number of processes to use for telemetry_unittests on win platform to be 1 to temporarily fix the race condition on win bot. BUG=559154 ========== to ========== Set the number of processes to use for telemetry_unittests on win platform to be 1 to temporarily fix the race condition on win bot. BUG=559154 NOTRY=true ==========
On 2015/11/23 19:28:50, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, > http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) Add NOTRY=true because linux_chromium_chromeos_rel_ng keeps failing.
The CQ bit was checked by nednguyen@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1471673003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1471673003/40001
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/b3b8c6ebf55d4bb55d728456dfc675115da45dce Cr-Commit-Position: refs/heads/master@{#361170}
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/1498093002/ by nednguyen@google.com. The reason for reverting is: crbug.com/559154 should be fixed. |
