Issue 1471653005: Mark tests that depend on destructuring as NeedsManualRebaseline

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1471653005: Mark tests that depend on destructuring as NeedsManualRebaseline (Closed)

Created:
5 years, 1 month ago by adamk

Modified:
5 years, 1 month ago

Reviewers:
ojan

CC:
chromium-reviews, blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Mark tests that depend on destructuring as NeedsManualRebaseline Destructuring will be turned on soon in v8, and that will cause these three tests to start "failing" (though they're actually passing more, since we support new syntax). Will rebaseline them after the change rolls successfully into Chromium. BUG=560503 TBR=ojan@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/bd1af97e265553077ae733a5e65adf56dd304a21

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	third_party/WebKit/LayoutTests/TestExpectations	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/bd1af97e265553077ae733a5e65adf56dd304a21 Cr-Commit-Position: refs/heads/master@{#361200}

5 years, 1 month ago (2015-11-23 22:21:31 UTC) #1

adamk

5 years, 1 month ago (2015-11-23 22:21:55 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
bd1af97e265553077ae733a5e65adf56dd304a21 (presubmit successful).