Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issue 1471653002: Assert that unit type conversion works in accumulateLengthArray (Closed)

Created:
5 years, 1 month ago by Timothy Loh
Modified:
5 years, 1 month ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Assert that unit type conversion works in accumulateLengthArray Committed: https://crrev.com/302e6f1e44602320dcb620db1c3bd2a5b5a6a138 Cr-Commit-Position: refs/heads/master@{#361260}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M third_party/WebKit/Source/core/css/CSSPrimitiveValue.cpp View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Timothy Loh
5 years, 1 month ago (2015-11-24 04:38:23 UTC) #2
alancutter (OOO until 2018)
lgtm
5 years, 1 month ago (2015-11-24 05:24:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1471653002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1471653002/1
5 years, 1 month ago (2015-11-24 05:26:57 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-24 05:34:09 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-24 05:35:25 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/302e6f1e44602320dcb620db1c3bd2a5b5a6a138
Cr-Commit-Position: refs/heads/master@{#361260}

Powered by Google App Engine
This is Rietveld 408576698