Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Issue 1471623005: PPC: [builtins] Sanitize the machinery around Construct calls. (Closed)

Created:
5 years ago by MTBrandyberry
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [builtins] Sanitize the machinery around Construct calls. Port 374b6ea210f0ce669cdec3bafd4a72dbba5fe2ad Original commit message: There's no point in collecting feedback for super constructor calls, because in all (interesting) cases we can gather (better) feedback from other sources (i.e. via inlining or via using a LOAD_IC to get to the [[Prototype]] of the target). So CallConstructStub is now only used for new Foo(...args) sites where we want to collect feedback in the baseline compiler. The optimizing compilers, Reflect.construct and super constructor calls use the Construct builtin directly, which allows us to remove some weird code from the CallConstructStub (and opens the possibility for more code sharing with the CallICStub, maybe even going for a ConstructICStub). Also remove the 100% redundant HCallNew instruction, which is just a wrapper for the Construct builtin anyway (indirectly via the CallConstructStub). Drive-by-fix: Drop unused has_function_cache bit on Code objects. R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG=v8:4413, v8:4430 LOG=n Committed: https://crrev.com/fe14ba45d656904e50d275a5d0b88342bf721eaf Cr-Commit-Position: refs/heads/master@{#32186}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -108 lines) Patch
M src/crankshaft/ppc/lithium-codegen-ppc.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M src/crankshaft/ppc/lithium-ppc.h View 2 chunks +0 lines, -20 lines 0 comments Download
M src/crankshaft/ppc/lithium-ppc.cc View 2 chunks +0 lines, -15 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 2 chunks +4 lines, -9 lines 0 comments Download
M src/ppc/builtins-ppc.cc View 2 chunks +10 lines, -9 lines 0 comments Download
M src/ppc/code-stubs-ppc.cc View 5 chunks +24 lines, -42 lines 0 comments Download
M src/ppc/interface-descriptors-ppc.cc View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
MTBrandyberry
5 years ago (2015-11-23 17:51:15 UTC) #1
michael_dawson
On 2015/11/23 17:51:15, mtbrandyberry wrote: lgtm
5 years ago (2015-11-23 18:48:35 UTC) #2
JoranSiu
On 2015/11/23 17:51:15, mtbrandyberry wrote: lgtm
5 years ago (2015-11-23 18:49:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1471623005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1471623005/1
5 years ago (2015-11-23 19:41:53 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-23 20:04:53 UTC) #6
commit-bot: I haz the power
5 years ago (2015-11-23 20:05:38 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fe14ba45d656904e50d275a5d0b88342bf721eaf
Cr-Commit-Position: refs/heads/master@{#32186}

Powered by Google App Engine
This is Rietveld 408576698