gdb-add-index: accept a list of files to index

gdb-add-index: accept a list of files to index

Previously gdb-add-index took a single binary argument to index. It uses
ldd to get its dependencies and index those too. Now it accepts more than
one file, along with a -n option to not attempt to extract dependencies.
This is useful for Android development where there's no single
binary to index. Now you can do gdb-add-index -n out/Debug/lib.unstripped/*

This CL also cleans up the style a bit for consistency.

BUG=

Committed: https://crrev.com/f94079e64790b85d3cdf7264b47c84ad7c9301f2
Cr-Commit-Position: refs/heads/master@{#361227}

[watk, 2015-11-21 03:06:37]

Description was changed from

==========
gdb-add-index: accept a list of files to index

Previously gdb-add-index took a single binary argument to index. It uses
ldd to get its dependencies and index those too. Now it accepts more than
one file, along with a -n option to not attempt to extract dependencies.
This is useful for Android development where there's no ldd and no single
binary to index. Now you can do gdb-add-index -n out/Debug/lib.unstripped/*

BUG=
==========

to

==========
gdb-add-index: accept a list of files to index

Previously gdb-add-index took a single binary argument to index. It uses
ldd to get its dependencies and index those too. Now it accepts more than
one file, along with a -n option to not attempt to extract dependencies.
This is useful for Android development where there's single
binary to index. Now you can do gdb-add-index -n out/Debug/lib.unstripped/*

This CL also cleans up the style a bit for consistency.

BUG=
==========

[watk, 2015-11-21 03:08:07]

watk@chromium.org changed reviewers:
+ agrieve@chromium.org

[watk, 2015-11-21 03:08:07]

Hey agrieve, please take a look

[agrieve, 2015-11-23 20:17:45]

On 2015/11/21 03:08:07, watk wrote:
> Hey agrieve, please take a look

lgtm. If you feel like touching such a script again though, please convert it to
python.

[agrieve, 2015-11-23 20:17:52]

https://codereview.chromium.org/1471523002/diff/20001/build/gdb-add-index
File build/gdb-add-index (right):

https://codereview.chromium.org/1471523002/diff/20001/build/gdb-add-index#new...
build/gdb-add-index:16: usage_exit() {
nit: use function keyword to match rest of file.

https://codereview.chromium.org/1471523002/diff/20001/build/gdb-add-index#new...
build/gdb-add-index:147: # Append the shared library dependencies of this file
that
nit: too much indent

[watk, 2015-11-23 20:45:36]

Thanks!

https://codereview.chromium.org/1471523002/diff/20001/build/gdb-add-index
File build/gdb-add-index (right):

https://codereview.chromium.org/1471523002/diff/20001/build/gdb-add-index#new...
build/gdb-add-index:147: # Append the shared library dependencies of this file
that
On 2015/11/23 20:17:52, agrieve wrote:
> nit: too much indent

Since this is a nit, I might leave it for now so I don't have to re-run my
manual tests :P re-writing in python sounds like a good idea.

[watk, 2015-11-23 23:28:01]

Description was changed from

==========
gdb-add-index: accept a list of files to index

Previously gdb-add-index took a single binary argument to index. It uses
ldd to get its dependencies and index those too. Now it accepts more than
one file, along with a -n option to not attempt to extract dependencies.
This is useful for Android development where there's single
binary to index. Now you can do gdb-add-index -n out/Debug/lib.unstripped/*

This CL also cleans up the style a bit for consistency.

BUG=
==========

to

==========
gdb-add-index: accept a list of files to index

Previously gdb-add-index took a single binary argument to index. It uses
ldd to get its dependencies and index those too. Now it accepts more than
one file, along with a -n option to not attempt to extract dependencies.
This is useful for Android development where there's no single
binary to index. Now you can do gdb-add-index -n out/Debug/lib.unstripped/*

This CL also cleans up the style a bit for consistency.

BUG=
==========

[watk, 2015-11-23 23:28:08]

The CQ bit was checked by watk@chromium.org

[watk, 2015-11-23 23:28:08]

The patchset sent to the CQ was uploaded after l-g-t-m from agrieve@chromium.org
Link to the patchset: https://codereview.chromium.org/1471523002/#ps40001
(title: "Nit")

[commit-bot: I haz the power, 2015-11-23 23:30:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1471523002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1471523002/40001

[commit-bot: I haz the power, 2015-11-24 00:30:40]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-11-24 00:31:31]

Patchset 3 (id:??) landed as
https://crrev.com/f94079e64790b85d3cdf7264b47c84ad7c9301f2
Cr-Commit-Position: refs/heads/master@{#361227}