LayoutTests/fast/css-grid-layout/resources/grid-item-column-row-parsing-utils.js - Issue 14715014: Add parsing for named grid lines

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/css-grid-layout/resources/grid-item-column-row-parsing-utils.js

Issue 14715014: Add parsing for named grid lines (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/css-grid-layout/grid-item-start-before-get-set-expected.txt ('k') | Source/core/css/CSSComputedStyleDeclaration.cpp » ('j') | Source/core/css/CSSParser.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/css-grid-layout/resources/grid-item-column-row-parsing-utils.js

diff --git a/LayoutTests/fast/css-grid-layout/resources/grid-item-column-row-parsing-utils.js b/LayoutTests/fast/css-grid-layout/resources/grid-item-column-row-parsing-utils.js

index 93bb9448e8c6bb613c4e93bde6097dfa5a6059c5..7d70a8a33e73560bd5d916b25c3cbe2db1a8a0c2 100644

--- a/LayoutTests/fast/css-grid-layout/resources/grid-item-column-row-parsing-utils.js

+++ b/LayoutTests/fast/css-grid-layout/resources/grid-item-column-row-parsing-utils.js

@@ -40,26 +40,36 @@ window.testColumnRowJSParsing = function(columnValue, rowValue, expectedColumnVa

document.body.removeChild(gridItem);

}

-window.testStartBeforeJSParsing = function(startValue, beforeValue)

+window.testStartBeforeJSParsing = function(startValue, beforeValue, expectedStartValue, expectedBeforeValue)

{

var gridItem = document.createElement("div");

document.body.appendChild(gridItem);

gridItem.style.webkitGridStart = startValue;

gridItem.style.webkitGridBefore = beforeValue;

- checkColumnRowValues(gridItem, startValue + " / auto", beforeValue + " / auto");

+ if (expectedStartValue === undefined)

+ expectedStartValue = startValue;

+ if (expectedBeforeValue === undefined)

+ expectedBeforeValue = beforeValue;

+ checkColumnRowValues(gridItem, expectedStartValue + " / auto", expectedBeforeValue + " / auto");

document.body.removeChild(gridItem);

}

-window.testEndAfterJSParsing = function(endValue, afterValue)

+window.testEndAfterJSParsing = function(endValue, afterValue, expectedEndValue, expectedAfterValue)

{

var gridItem = document.createElement("div");

document.body.appendChild(gridItem);

gridItem.style.webkitGridEnd = endValue;

gridItem.style.webkitGridAfter = afterValue;

- checkColumnRowValues(gridItem, "auto / " + endValue, "auto / " + afterValue);

+ if (expectedEndValue === undefined)

+ expectedEndValue = endValue;

+ if (expectedAfterValue === undefined)

+ expectedAfterValue = afterValue;

+ checkColumnRowValues(gridItem, "auto / " + expectedEndValue, "auto / " + expectedAfterValue);

document.body.removeChild(gridItem);

}