Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: LayoutTests/fast/css-grid-layout/grid-item-start-before-get-set.html

Issue 14715014: Add parsing for named grid lines (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/fast/css-grid-layout/grid-item-start-before-get-set.html
diff --git a/LayoutTests/fast/css-grid-layout/grid-item-start-before-get-set.html b/LayoutTests/fast/css-grid-layout/grid-item-start-before-get-set.html
index 09e9ec5cd11441e13e388aa48a56e84bdb67ed68..d238d6a0f33e50cb47e5b3d45a7789607d1a471b 100644
--- a/LayoutTests/fast/css-grid-layout/grid-item-start-before-get-set.html
+++ b/LayoutTests/fast/css-grid-layout/grid-item-start-before-get-set.html
@@ -30,6 +30,18 @@ if (window.testRunner)
-webkit-grid-start: auto;
-webkit-grid-before: auto;
}
+.gridItemWithString {
+ -webkit-grid-start: "first";
+ -webkit-grid-before: "last";
+}
+.gridItemWithSpanString {
+ -webkit-grid-start: "first" span;
+ -webkit-grid-before: span "last";
+}
+.gridItemWithSpanNumberString {
+ -webkit-grid-start: 2 "first" span;
+ -webkit-grid-before: "last" 3 span;
+}
</style>
<script src="resources/grid-item-column-row-parsing-utils.js"></script>
<script src="../js/resources/js-test-pre.js"></script>
@@ -43,6 +55,9 @@ if (window.testRunner)
<div class="gridItemWithAfterSpan" id="gridItemWithAfterSpan"></div>
<div class="gridItemWithOnlySpan" id="gridItemWithOnlySpan"></div>
<div class="gridItemWithAuto" id="gridItemWithAutoElement"></div>
+<div class="gridItemWithString" id="gridItemWithStringElement"></div>
+<div class="gridItemWithSpanString" id="gridItemWithSpanStringElement"></div>
+<div class="gridItemWithSpanNumberString" id="gridItemWithSpanNumberStringElement"></div>
<script>
description('Test that setting and getting grid-start and grid-before works as expected');
@@ -59,6 +74,9 @@ if (window.testRunner)
testColumnRowCSSParsing("gridItemWithAfterSpan", "span 2 / auto", "span 8 / auto");
testColumnRowCSSParsing("gridItemWithOnlySpan", "span 1 / auto", "span 1 / auto");
testColumnRowCSSParsing("gridItemWithAutoElement", "auto / auto", "auto / auto");
+ testColumnRowCSSParsing("gridItemWithStringElement", "1 first / auto", "1 last / auto");
+ testColumnRowCSSParsing("gridItemWithSpanStringElement", "span 1 first / auto", "span 1 last / auto");
+ testColumnRowCSSParsing("gridItemWithSpanNumberStringElement", "span 2 first / auto", "span 3 last / auto");
debug("");
debug("Test the initial value");
@@ -73,7 +91,9 @@ if (window.testRunner)
debug("Test getting and setting grid-start and grid-before through JS");
testStartBeforeJSParsing("18", "66");
testStartBeforeJSParsing("-55", "-40");
+ testStartBeforeJSParsing("'nav'", "'last'", "1 nav", "1 last");
testStartBeforeJSParsing("span 3", "span 20");
+ testStartBeforeJSParsing("span 'nav'", "span 'last'", "span 1 nav", "span 1 last");
testStartBeforeJSParsing("auto", "auto");
debug("");

Powered by Google App Engine
This is Rietveld 408576698