Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1053)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1471453003: Remove offline copy when the URL of a bookmark is changed (Closed)

Created:
5 years, 1 month ago by jianli
Modified:
5 years ago
Reviewers:
fgorski
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove offline copy when the URL of a bookmark is changed BUG=558929 Committed: https://crrev.com/0263efb511668695fff0c61675f1d4734ea8de85 Cr-Commit-Position: refs/heads/master@{#360987}

Patch Set 1 #

Patch Set 2 : Patch to land #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M components/offline_pages/offline_page_model.h View 1 chunk +2 lines, -0 lines 0 comments Download
M components/offline_pages/offline_page_model.cc View 1 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
jianli
5 years, 1 month ago (2015-11-20 23:28:40 UTC) #3
jianli
5 years, 1 month ago (2015-11-20 23:28:40 UTC) #4
fgorski
lgtm
5 years, 1 month ago (2015-11-20 23:32:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1471453003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1471453003/20001
5 years, 1 month ago (2015-11-20 23:38:44 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/138417)
5 years, 1 month ago (2015-11-21 01:23:50 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1471453003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1471453003/20001
5 years, 1 month ago (2015-11-21 01:29:46 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-11-21 02:18:30 UTC) #13
commit-bot: I haz the power
5 years ago (2015-11-21 02:19:12 UTC) #14
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/0263efb511668695fff0c61675f1d4734ea8de85
Cr-Commit-Position: refs/heads/master@{#360987}

Powered by Google App Engine
This is Rietveld 408576698