Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 1471403002: Look inside inner nested multicols to calculate minimum space shortage. (Closed)

Created:
5 years ago by mstensho (USE GERRIT)
Modified:
3 years, 3 months ago
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, mstensho (USE GERRIT), pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Look inside inner nested multicols to calculate minimum space shortage. This is needed in order to make sure that the column balancer gives us as short outer columns as possible. Otherwise we risk not finding the absolute minimum space shortage (and thus over-stretch) (or, even worse, not be able to find any shortage at all). BUG=447718 R=leviw@chromium.org Committed: https://crrev.com/b8744f29d5d5a8ad70f27720a0a1aea177ba571b Cr-Commit-Position: refs/heads/master@{#361501}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/fast/multicol/nested-uneven-inner-column-height.html View 1 chunk +18 lines, -0 lines 1 comment Download
A third_party/WebKit/LayoutTests/fast/multicol/nested-uneven-inner-column-height-expected.txt View 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ColumnBalancer.cpp View 2 chunks +14 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
mstensho (USE GERRIT)
Here's a fix for what's really causing the svg/text/layout-inline-children-assert.html crash when applying https://codereview.chromium.org/1472053002/
5 years ago (2015-11-24 20:57:21 UTC) #1
leviw_travelin_and_unemployed
https://codereview.chromium.org/1471403002/diff/1/third_party/WebKit/LayoutTests/fast/multicol/nested-uneven-inner-column-height.html File third_party/WebKit/LayoutTests/fast/multicol/nested-uneven-inner-column-height.html (right): https://codereview.chromium.org/1471403002/diff/1/third_party/WebKit/LayoutTests/fast/multicol/nested-uneven-inner-column-height.html#newcode4 third_party/WebKit/LayoutTests/fast/multicol/nested-uneven-inner-column-height.html:4: should read "SART". The second one should read "KU". ...
5 years ago (2015-11-24 21:39:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1471403002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1471403002/1
5 years ago (2015-11-24 21:44:15 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-25 00:45:27 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b8744f29d5d5a8ad70f27720a0a1aea177ba571b Cr-Commit-Position: refs/heads/master@{#361501}
5 years ago (2015-11-25 00:47:17 UTC) #6
fileorgin
On 2015/11/25 00:47:17, commit-bot: I haz the power wrote: > Patchset 1 (id:??) landed as ...
3 years, 8 months ago (2017-04-13 12:39:52 UTC) #7
ryandennis135
3 years, 3 months ago (2017-09-23 10:15:44 UTC) #8
Message was sent while issue was closed.
On 2017/04/13 12:39:52, fileorgin wrote:
> On 2015/11/25 00:47:17, commit-bot: I haz the power wrote:
> > Patchset 1 (id:??) landed as
> > https://crrev.com/b8744f29d5d5a8ad70f27720a0a1aea177ba571b
> > Cr-Commit-Position: refs/heads/master@{#361501}
> 
> KingrootAPK:
https://apkauthority.com/kingroot-apk-download-for-free-one-touch-root

Powered by Google App Engine
This is Rietveld 408576698