Issue 14714004: Fix incremental marking speed accelleration and start incremental marking when old space is almost …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14714004: Fix incremental marking speed accelleration and start incremental marking when old space is almost … (Closed)

Created:
7 years, 7 months ago by Hannes Payer (out of office)

Modified:
7 years, 7 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix incremental marking speed accelleration and start incremental marking when old space is almost full when pretenuring objects. BUG= Committed: https://code.google.com/p/v8/source/detail?r=14559

Patch Set 2 : #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -5 lines)			Patch
	M	src/incremental-marking.h	View		1 chunk	+1 line, -4 lines	0 comments	Download
	M	src/incremental-marking.cc	View	1	3 chunks	+24 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM with a nit. https://codereview.chromium.org/14714004/diff/1/src/incremental-marking.cc File src/incremental-marking.cc (right): https://codereview.chromium.org/14714004/diff/1/src/incremental-marking.cc#newcode873 src/incremental-marking.cc:873: !FLAG_incremental_marking || nit: Indentation if ...

7 years, 7 months ago (2013-05-06 16:15:18 UTC) #2

Hannes Payer (out of office)

https://codereview.chromium.org/14714004/diff/1/src/incremental-marking.cc File src/incremental-marking.cc (right): https://codereview.chromium.org/14714004/diff/1/src/incremental-marking.cc#newcode873 src/incremental-marking.cc:873: !FLAG_incremental_marking || On 2013/05/06 16:15:18, Michael Starzinger wrote: > ...

7 years, 7 months ago (2013-05-06 16:17:36 UTC) #3

Hannes Payer (out of office)

7 years, 7 months ago (2013-05-06 16:17:55 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r14559 (presubmit successful).

Expand Messages | Collapse Messages

Issue 14714004: Fix incremental marking speed accelleration and start incremental marking when old space is almost … (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages