build/android/gyp/write_build_config.py - Issue 1471393002: GN Incremental Install: Don't use proguarded dex when is_debug = false

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/gyp/write_build_config.py

Issue 1471393002: GN Incremental Install: Don't use proguarded dex when is_debug = false (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add warning Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/gyp/write_build_config.py

diff --git a/build/android/gyp/write_build_config.py b/build/android/gyp/write_build_config.py

index 625107f5dcdc643fcd8abc8e9242080eb545c223..b8b8ec8c748827569799b6c63ef4e11078b4168a 100755

--- a/build/android/gyp/write_build_config.py

+++ b/build/android/gyp/write_build_config.py

@@ -395,10 +395,6 @@ def main(argv):

if options.type in ['android_apk', 'deps_dex']:

config['final_dex'] = {}

dex_config = config['final_dex']

- if proguard_enabled:

- # When proguard is enabled, the proguarded jar contains the code for all

- # of the dependencies.

- deps_dex_files = []

dex_config['dependency_dex_files'] = deps_dex_files

if options.type == 'android_apk':

« no previous file with comments | « no previous file | build/android/incremental_install/create_install_script.py » ('j') | no next file with comments »