Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(868)

Unified Diff: tools/dm_flags.py

Issue 1471373003: Add frame_larger_than_image.gif to blacklist (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/dm_flags.json ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/dm_flags.py
diff --git a/tools/dm_flags.py b/tools/dm_flags.py
index 5341b221da1b1068fb72500016f98f9d48f9cb27..052be598c3005ff130900525854afc872993fc77 100755
--- a/tools/dm_flags.py
+++ b/tools/dm_flags.py
@@ -111,6 +111,10 @@ def get_args(bot):
# New ico files that fail on SkImageDecoder
blacklist.extend('_ image decode Hopstarter-Mac-Folders-Apple.ico'.split(' '))
+ # Gif test image uses uninitialized memory on Mac bots
+ if 'Mac' in bot:
+ blacklist.extend('_ image decode frame_larger_than_image.gif'.split(' '))
+
# Incomplete image tests that fail on SkImageDecoder
blacklist.extend('_ image decode inc0.gif'.split(' '))
blacklist.extend('_ image decode inc1.gif'.split(' '))
@@ -212,6 +216,7 @@ def self_test():
'Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-TSAN',
'Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Valgrind',
'Test-Win7-MSVC-ShuttleA-GPU-HD2000-x86-Debug-ANGLE',
+ 'Test-Mac10.8-Clang-MacMini4.1-CPU-SSE4-x86_64-Release',
]
cov = coverage.coverage()
« no previous file with comments | « tools/dm_flags.json ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698