Remove the clip argument to WebContentLayerClient::paintContents.

Remove the clip argument to WebContentLayerClient::paintContents.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/28d99af9a614bfddff9fad8bb69f47a94140b956
Cr-Commit-Position: refs/heads/master@{#362554}

[chrishtr, 2015-11-25 22:37:07]

Description was changed from

==========
none

BUG=
==========

to

==========
none

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[chrishtr, 2015-11-25 22:38:16]

Description was changed from

==========
none

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Remove the clip argument to WebContentLayerClient::paintContents.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[chrishtr, 2015-12-01 20:40:41]

chrishtr@chromium.org changed reviewers:
+ jbroman@chromium.org

[jbroman, 2015-12-01 21:11:02]

lgtm if bots agree, modulo one comment

https://codereview.chromium.org/1471323006/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp (right):

https://codereview.chromium.org/1471323006/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp:305: void
GraphicsLayer::paint(GraphicsContext& context, const IntRect* interestRect)
Is the plan to ultimately remove the argument from this method too? I can't tell
from either GraphicsLayer or GraphicsContextPainter what the conditions are
where one should expect this to be provided and where it should be null.

[chrishtr, 2015-12-01 21:14:05]

On 2015/12/01 at 21:11:02, jbroman wrote:
> lgtm if bots agree, modulo one comment
> 
>
https://codereview.chromium.org/1471323006/diff/40001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp (right):
> 
>
https://codereview.chromium.org/1471323006/diff/40001/third_party/WebKit/Sour...
> third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp:305: void
GraphicsLayer::paint(GraphicsContext& context, const IntRect* interestRect)
> Is the plan to ultimately remove the argument from this method too? I can't
tell from either GraphicsLayer or GraphicsContextPainter what the conditions are
where one should expect this to be provided and where it should be null.

Yes, but right now the tests require it. Sorry for the intermediate state of
this code. :(

[chrishtr, 2015-12-01 21:14:15]

The CQ bit was checked by chrishtr@chromium.org

[commit-bot: I haz the power, 2015-12-01 21:17:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1471323006/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1471323006/40001

[commit-bot: I haz the power, 2015-12-01 22:19:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-01 22:19:23]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[enne (OOO), 2015-12-01 22:53:54]

enne@chromium.org changed reviewers:
+ enne@chromium.org

[enne (OOO), 2015-12-01 22:53:55]

lgtm

[chrishtr, 2015-12-01 22:56:47]

The CQ bit was checked by chrishtr@chromium.org

[commit-bot: I haz the power, 2015-12-01 22:57:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1471323006/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1471323006/40001

[commit-bot: I haz the power, 2015-12-01 23:58:12]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-12-02 00:02:48]

Description was changed from

==========
Remove the clip argument to WebContentLayerClient::paintContents.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Remove the clip argument to WebContentLayerClient::paintContents.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/28d99af9a614bfddff9fad8bb69f47a94140b956
Cr-Commit-Position: refs/heads/master@{#362554}
==========

[commit-bot: I haz the power, 2015-12-02 00:02:48]

Patchset 3 (id:??) landed as
https://crrev.com/28d99af9a614bfddff9fad8bb69f47a94140b956
Cr-Commit-Position: refs/heads/master@{#362554}