Retain the unstripped nexe at a predictable location.

Retain the unstripped nexe at a predictable location.

Retaining the unstripped nexe at a predictable location in order to allow us to
archive a copy of the unstripped IRT, and to have it available locally.
Add a gnu_debuglink link to the stripped irt (and other nexes/so) to facilitate the debugger finding the debugging info.

Now that we have a process to retain debug info, strip fully for irt_core and tests.

BUG=http://code.google.com/p/chromium/issues/detail?id=117242
TEST=builds
R=jvoung@chromium.org

Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=11290

[khimg, 2013-05-01 01:09:55]

Flyby comment: why not create standard .dbg file linked to .nexe?

http://sourceware.org/gdb/download/onlinedocs/gdb/Separate-Debug-Files.html#S...

[jvoung (off chromium), 2013-05-01 19:29:00]

lgtm

[Mark Seaborn, 2013-05-01 20:33:20]

On 2013/05/01 01:09:55, khimg wrote:
> Flyby comment: why not create standard .dbg file linked to .nexe?
> 
>
http://sourceware.org/gdb/download/onlinedocs/gdb/Separate-Debug-Files.html#S...

Forwarding Brad's reply for the record:

On 1 May 2013 13:20, Bradley Nelson <bradnelson@google.com> wrote:
> Sorry to have been slow in replying Victor, I've been out at a training class
this morning.
> I'd actually intended to act on your suggestion, but haven't looked into it
yet.
> One minor concern Roland raised was whether it might be better to also keep
the full irt content but setup the debugging link, as the debugging link feature
is sightly harder for those unfamiliar with it to setup.
> Also I was going to look into what if any existing conventions with this exist
for chrome linux builds.
> More soon...
>
> -BradN

[bradn, 2013-05-02 20:06:10]

Ok, switched to .debug, and adding the gnu_debuglink.
This would use the crc for now, later iterations of the toolchain will magically
turn on the use of build-id.

[bradn, 2013-05-02 22:48:28]

Committed patchset #5 manually as r11290 (presubmit successful).

[khim, 2013-05-03 11:39:44]

On Fri, May 3, 2013 at 12:06 AM, <bradnelson@google.com> wrote:

> Ok, switched to .debug, and adding the gnu_debuglink.
>

Sadly this fails on nacl_sdk bots:
http://build.chromium.org/p/tryserver.chromium/builders/linux_nacl_sdk/builds...

/bin/sh: 1:
../../../../../out/gypbuild-pnacl-arm/Release/gen/sdk/toolchain/linux_x86_pnacl/newlib/bin/pnacl-objcopy:
not found


Probably the simplest fix is to disable it for pnacl ...

This would use the crc for now, later iterations of the toolchain will
> magically
> turn on the use of build-id.
>
>
>
>
https://codereview.chromium.**org/14713006/<https://codereview.chromium.org/1...
>
> --
> You received this message because you are subscribed to the Google Groups
> "Native-Client-Reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
native-client-reviews+**unsubscribe@googlegroups.com<native-client-reviews%2B...
> .
> To post to this group, send email to native-client-reviews@**
> googlegroups.com <native-client-reviews@googlegroups.com>.
> Visit this group at http://groups.google.com/**
>
group/native-client-reviews?**hl=en<http://groups.google.com/group/native-client-reviews?hl=en>
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>
>
>

-- 
You received this message because you are subscribed to the Google Groups
"Native-Client-Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to native-client-reviews+unsubscribe@googlegroups.com.
To post to this group, send email to native-client-reviews@googlegroups.com.
Visit this group at http://groups.google.com/group/native-client-reviews?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.

[bradn, 2013-05-03 15:45:22]

Oops, didn't think thru that case.
Sorry apparently or default trybot list doesn't cover the right stuff.

-BradN


On Fri, May 3, 2013 at 4:39 AM, Victor Khimenko <khim@chromium.org> wrote:

>
> On Fri, May 3, 2013 at 12:06 AM, <bradnelson@google.com> wrote:
>
>> Ok, switched to .debug, and adding the gnu_debuglink.
>>
>
> Sadly this fails on nacl_sdk bots:
>
>
http://build.chromium.org/p/tryserver.chromium/builders/linux_nacl_sdk/builds...
>
> /bin/sh: 1:
../../../../../out/gypbuild-pnacl-arm/Release/gen/sdk/toolchain/linux_x86_pnacl/newlib/bin/pnacl-objcopy:
not found
>
>
> Probably the simplest fix is to disable it for pnacl ...
>
> This would use the crc for now, later iterations of the toolchain will
>> magically
>> turn on the use of build-id.
>>
>>
>>
>>
https://codereview.chromium.**org/14713006/<https://codereview.chromium.org/1...
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "Native-Client-Reviews" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to
native-client-reviews+**unsubscribe@googlegroups.com<native-client-reviews%2B...
>> .
>> To post to this group, send email to native-client-reviews@**
>> googlegroups.com <native-client-reviews@googlegroups.com>.
>> Visit this group at http://groups.google.com/**
>>
group/native-client-reviews?**hl=en<http://groups.google.com/group/native-client-reviews?hl=en>
>> .
>> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
>> .
>>
>>
>>
>

-- 
You received this message because you are subscribed to the Google Groups
"Native-Client-Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to native-client-reviews+unsubscribe@googlegroups.com.
To post to this group, send email to native-client-reviews@googlegroups.com.
Visit this group at http://groups.google.com/group/native-client-reviews?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.

[mseaborn - please use other, 2013-05-03 18:10:10]

On 3 May 2013 04:39, Victor Khimenko <khim@chromium.org> wrote:

> On Fri, May 3, 2013 at 12:06 AM, <bradnelson@google.com> wrote:
>
>> Ok, switched to .debug, and adding the gnu_debuglink.
>>
>
> Sadly this fails on nacl_sdk bots:
>
>
http://build.chromium.org/p/tryserver.chromium/builders/linux_nacl_sdk/builds...
>
> /bin/sh: 1:
../../../../../out/gypbuild-pnacl-arm/Release/gen/sdk/toolchain/linux_x86_pnacl/newlib/bin/pnacl-objcopy:
not found
>
>
> Probably the simplest fix is to disable it for pnacl ...
>

I get the same error when attempting to roll nacl_revision in Chromium's
DEPS:

chromeos-chrome-28.0.1497.1_rc-r1: /bin/sh:
/home/chrome-bot/chrome_root/src/c/Release/obj/gen/sdk/toolchain/linux_x86_pnacl/newlib/bin/pnacl-objcopy:
No such file or directory
chromeos-chrome-28.0.1497.1_rc-r1: Err 127: nacl-pnacl-objcopy
/home/chrome-bot/chrome_root/src/c/Release/obj/gen/tc_pnacl_translate/lib-arm/libpnacl_irt_shim.a
- see
http://build.chromium.org/p/tryserver.chromium/builders/cros_daisy/builds/170...
and https://codereview.chromium.org/14771013/

I'm closing the NaCl tree until this is verified as fixed.

Mark

-- 
You received this message because you are subscribed to the Google Groups
"Native-Client-Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to native-client-reviews+unsubscribe@googlegroups.com.
To post to this group, send email to native-client-reviews@googlegroups.com.
Visit this group at http://groups.google.com/group/native-client-reviews?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.