third_party/WebKit/Source/core/events/PromiseRejectionEvent.cpp - Issue 1471283002: Update PromiseRejectionEvent IDL to match latest spec

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/events/PromiseRejectionEvent.cpp

Issue 1471283002: Update PromiseRejectionEvent IDL to match latest spec (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/events/constructors/promise-rejection-event-constructor.html ('k') | third_party/WebKit/Source/core/events/PromiseRejectionEvent.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/events/PromiseRejectionEvent.cpp

diff --git a/third_party/WebKit/Source/core/events/PromiseRejectionEvent.cpp b/third_party/WebKit/Source/core/events/PromiseRejectionEvent.cpp

index a1333b4117036e41a40883283aa10218f1a7d766..a949d4b37d1c96320384de62a1b4dd1e8dee21f7 100644

--- a/third_party/WebKit/Source/core/events/PromiseRejectionEvent.cpp

+++ b/third_party/WebKit/Source/core/events/PromiseRejectionEvent.cpp

@@ -44,7 +44,7 @@ ScriptValue PromiseRejectionEvent::reason(ScriptState* state) const

{

// Return null when the value is accessed by a different world than the world that created the value.

if (m_reason.isEmpty() || !m_scriptState || !m_scriptState->contextIsValid() || m_scriptState->world().worldId() != state->world().worldId())

- return ScriptValue(state, v8::Null(state->isolate()));

+ return ScriptValue(state, v8::Undefined(state->isolate()));

return ScriptValue(m_scriptState.get(), m_reason.newLocal(m_scriptState->isolate()));

}