Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 1471273002: Remove ContentMain.initApplicationContext. (Closed)

Created:
5 years ago by Torne
Modified:
5 years ago
Reviewers:
Yaron
CC:
chromium-reviews, darin-cc_chromium.org, jam, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ContentMain.initApplicationContext. Just have callers call ContextUtils.initApplicationContext instead, the extra indirection isn't useful. BUG=552419 R=yfriedman@chromium.org Committed: https://crrev.com/f07dcdcecca50332469399f9f7632dfcac676e4c Cr-Commit-Position: refs/heads/master@{#361384}

Patch Set 1 #

Messages

Total messages: 10 (1 generated)
Torne
5 years ago (2015-11-24 16:25:01 UTC) #1
Yaron
lgtm
5 years ago (2015-11-24 16:26:11 UTC) #2
Yaron
On 2015/11/24 16:26:11, Yaron wrote: > lgtm Or do you need to split the aw/glue ...
5 years ago (2015-11-24 16:27:54 UTC) #3
Yaron
On 2015/11/24 16:26:11, Yaron wrote: > lgtm Or do you need to split the aw/glue ...
5 years ago (2015-11-24 16:27:55 UTC) #4
Torne
On 2015/11/24 16:27:55, Yaron wrote: > On 2015/11/24 16:26:11, Yaron wrote: > > lgtm > ...
5 years ago (2015-11-24 16:40:08 UTC) #5
Yaron
On 2015/11/24 16:40:08, Torne wrote: > On 2015/11/24 16:27:55, Yaron wrote: > > On 2015/11/24 ...
5 years ago (2015-11-24 16:43:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1471273002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1471273002/1
5 years ago (2015-11-24 16:44:35 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-24 18:00:23 UTC) #9
commit-bot: I haz the power
5 years ago (2015-11-24 18:01:27 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f07dcdcecca50332469399f9f7632dfcac676e4c
Cr-Commit-Position: refs/heads/master@{#361384}

Powered by Google App Engine
This is Rietveld 408576698