Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1089)

Issue 1471263002: Fix win/gn build after https://codereview.chromium.org/1452353002 (Closed)

Created:
5 years ago by Nico
Modified:
5 years ago
Reviewers:
chrishtr
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix win/gn build after https://codereview.chromium.org/1452353002 That change added gfx_geometry as a dep in .gyp files, but forgot to do the same for .gn files, which broke the Windows component builders. (The Linux component build seems to inline this function, I guess.) Due to crbug.com/497970, this breakage went undetected for pretty long. BUG=486089, 552545 TBR=christhr Committed: https://crrev.com/8a9549a6fb77ee6d7a6154aa163243f94712784d Cr-Commit-Position: refs/heads/master@{#361369}

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix comma too #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M third_party/WebKit/Source/platform/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/blink_platform.gyp View 1 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/web.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
Nico
5 years ago (2015-11-24 15:48:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1471263002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1471263002/1
5 years ago (2015-11-24 15:49:28 UTC) #5
chrishtr
Thanks! Sorry for missing the GN files.
5 years ago (2015-11-24 15:54:22 UTC) #6
Nico
On 2015/11/24 15:54:22, chrishtr wrote: > Thanks! Sorry for missing the GN files. Not a ...
5 years ago (2015-11-24 16:01:00 UTC) #8
Nico
https://codereview.chromium.org/1471263002/diff/1/third_party/WebKit/Source/platform/blink_platform.gyp File third_party/WebKit/Source/platform/blink_platform.gyp (left): https://codereview.chromium.org/1471263002/diff/1/third_party/WebKit/Source/platform/blink_platform.gyp#oldcode200 third_party/WebKit/Source/platform/blink_platform.gyp:200: '<(DEPTH)/ui/gfx/gfx.gyp:gfx_geometry' ooooh this was also missing the trailing comma, ...
5 years ago (2015-11-24 16:30:20 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1471263002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1471263002/20001
5 years ago (2015-11-24 16:33:55 UTC) #11
Nico
Committed patchset #2 (id:20001) manually as 8a9549a6fb77ee6d7a6154aa163243f94712784d (presubmit successful).
5 years ago (2015-11-24 16:55:35 UTC) #12
commit-bot: I haz the power
5 years ago (2015-11-24 16:55:37 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8a9549a6fb77ee6d7a6154aa163243f94712784d
Cr-Commit-Position: refs/heads/master@{#361369}

Powered by Google App Engine
This is Rietveld 408576698