Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 1471233002: Add repeat_delay_ms and repeat_count as configurable parameters to the infinit scrolling benchmarks. (Closed)

Created:
5 years ago by Hannes Payer (out of office)
Modified:
5 years ago
Reviewers:
ulan, Sami
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add repeat_delay_ms and repeat_count as configurable parameters to the infinit scrolling benchmarks. Twitter gets stuck most of the time when we scroll continuously. Non-continuous scrolling fixes the issue. BUG= Committed: https://crrev.com/9448d563c2e7698cae478844e58c7cb4920a1cd1 Cr-Commit-Position: refs/heads/master@{#361348}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -12 lines) Patch
M tools/perf/page_sets/infinite_scroll_cases.py View 1 4 chunks +17 lines, -12 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Hannes Payer (out of office)
5 years ago (2015-11-24 13:50:57 UTC) #3
ulan
lgtm
5 years ago (2015-11-24 14:05:36 UTC) #4
Sami
lgtm
5 years ago (2015-11-24 15:25:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1471233002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1471233002/20001
5 years ago (2015-11-24 15:26:22 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-11-24 16:08:03 UTC) #8
commit-bot: I haz the power
5 years ago (2015-11-24 16:08:58 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9448d563c2e7698cae478844e58c7cb4920a1cd1
Cr-Commit-Position: refs/heads/master@{#361348}

Powered by Google App Engine
This is Rietveld 408576698