Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 147123010: Re-enable the two blink heap unit tests. (Closed)

Created:
6 years, 10 months ago by wibling-chromium
Modified:
6 years, 10 months ago
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

Re-enable the two blink heap unit tests. These should work now after fixing bug 340591. R=ager@chromium.org, erik.corry@gmail.com, haraken@chromium.org, vegorov@chromium.org, zerny@chromium.org BUG=340591 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=249388

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M build/android/pylib/gtest/filter/blink_heap_unittests_disabled View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
wibling-chromium
6 years, 10 months ago (2014-02-06 08:48:58 UTC) #1
Mads Ager (chromium)
LGTM
6 years, 10 months ago (2014-02-06 08:51:11 UTC) #2
Mads Ager (chromium)
Could you add the bug number to the BUG= line?
6 years, 10 months ago (2014-02-06 08:51:40 UTC) #3
haraken
LGTM
6 years, 10 months ago (2014-02-06 08:52:16 UTC) #4
wibling-chromium
On 2014/02/06 08:51:40, Mads Ager (chromium) wrote: > Could you add the bug number to ...
6 years, 10 months ago (2014-02-06 08:57:27 UTC) #5
wibling-chromium
The CQ bit was checked by wibling@chromium.org
6 years, 10 months ago (2014-02-06 08:57:48 UTC) #6
zerny-chromium
lgtm
6 years, 10 months ago (2014-02-06 08:59:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wibling@chromium.org/147123010/1
6 years, 10 months ago (2014-02-06 09:02:29 UTC) #8
commit-bot: I haz the power
6 years, 10 months ago (2014-02-06 12:24:37 UTC) #9
Message was sent while issue was closed.
Change committed as 249388

Powered by Google App Engine
This is Rietveld 408576698