Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14712010: Revert 199633 "Doc server manifest page generation" (Closed)

Created:
7 years, 7 months ago by not at google - send to devlin
Modified:
7 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 199633 "Doc server manifest page generation" > Doc server manifest page generation > > The manifest page is now unique for apps and extensions and the property descriptions have their own pages. > > BUG=233966 > NOTRY=true > R=kalman@chromium.org > > Review URL: https://codereview.chromium.org/14273041 TBR=kalman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199634

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -1205 lines) Patch
M trunk/src/chrome/common/extensions/docs/server2/app.yaml View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/common/extensions/docs/server2/cron.yaml View 1 chunk +4 lines, -4 lines 0 comments Download
M trunk/src/chrome/common/extensions/docs/server2/intro_data_source.py View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/chrome/common/extensions/docs/server2/local_renderer.py View 1 chunk +1 line, -1 line 0 comments Download
D trunk/src/chrome/common/extensions/docs/server2/manifest_data_source.py View 1 chunk +0 lines, -90 lines 0 comments Download
D trunk/src/chrome/common/extensions/docs/server2/manifest_data_source_test.py View 1 chunk +0 lines, -128 lines 0 comments Download
M trunk/src/chrome/common/extensions/docs/server2/server_instance.py View 3 chunks +15 lines, -9 lines 0 comments Download
M trunk/src/chrome/common/extensions/docs/server2/sidenav_data_source.py View 2 chunks +7 lines, -3 lines 0 comments Download
M trunk/src/chrome/common/extensions/docs/server2/subversion_file_system.py View 1 chunk +3 lines, -2 lines 0 comments Download
M trunk/src/chrome/common/extensions/docs/server2/subversion_file_system_test.py View 2 chunks +7 lines, -44 lines 0 comments Download
M trunk/src/chrome/common/extensions/docs/server2/template_data_source.py View 9 chunks +3 lines, -8 lines 0 comments Download
M trunk/src/chrome/common/extensions/docs/server2/template_data_source_test.py View 3 chunks +0 lines, -4 lines 0 comments Download
D trunk/src/chrome/common/extensions/docs/templates/articles/apps_manifest.html View 1 chunk +0 lines, -20 lines 0 comments Download
D trunk/src/chrome/common/extensions/docs/templates/articles/extensions_manifest.html View 1 chunk +0 lines, -20 lines 0 comments Download
D trunk/src/chrome/common/extensions/docs/templates/articles/manifest/app.html View 1 chunk +0 lines, -8 lines 0 comments Download
D trunk/src/chrome/common/extensions/docs/templates/articles/manifest/default_locale.html View 1 chunk +0 lines, -12 lines 0 comments Download
D trunk/src/chrome/common/extensions/docs/templates/articles/manifest/description.html View 1 chunk +0 lines, -13 lines 0 comments Download
D trunk/src/chrome/common/extensions/docs/templates/articles/manifest/file_handlers.html View 1 chunk +0 lines, -42 lines 0 comments Download
D trunk/src/chrome/common/extensions/docs/templates/articles/manifest/homepage_url.html View 1 chunk +0 lines, -9 lines 0 comments Download
D trunk/src/chrome/common/extensions/docs/templates/articles/manifest/icons.html View 1 chunk +0 lines, -52 lines 0 comments Download
D trunk/src/chrome/common/extensions/docs/templates/articles/manifest/incognito.html View 1 chunk +0 lines, -32 lines 0 comments Download
D trunk/src/chrome/common/extensions/docs/templates/articles/manifest/key.html View 1 chunk +0 lines, -28 lines 0 comments Download
D trunk/src/chrome/common/extensions/docs/templates/articles/manifest/kiosk_enabled.html View 1 chunk +0 lines, -8 lines 0 comments Download
D trunk/src/chrome/common/extensions/docs/templates/articles/manifest/manifest_version.html View 1 chunk +0 lines, -31 lines 0 comments Download
D trunk/src/chrome/common/extensions/docs/templates/articles/manifest/minimum_chrome_version.html View 1 chunk +0 lines, -6 lines 0 comments Download
D trunk/src/chrome/common/extensions/docs/templates/articles/manifest/nacl_modules.html View 1 chunk +0 lines, -62 lines 0 comments Download
D trunk/src/chrome/common/extensions/docs/templates/articles/manifest/name.html View 1 chunk +0 lines, -12 lines 0 comments Download
D trunk/src/chrome/common/extensions/docs/templates/articles/manifest/offline_enabled.html View 1 chunk +0 lines, -7 lines 0 comments Download
D trunk/src/chrome/common/extensions/docs/templates/articles/manifest/requirements.html View 1 chunk +0 lines, -47 lines 0 comments Download
D trunk/src/chrome/common/extensions/docs/templates/articles/manifest/sandbox.html View 1 chunk +0 lines, -67 lines 0 comments Download
D trunk/src/chrome/common/extensions/docs/templates/articles/manifest/version.html View 1 chunk +0 lines, -48 lines 0 comments Download
D trunk/src/chrome/common/extensions/docs/templates/articles/manifest/web_accessible_resources.html View 1 chunk +0 lines, -59 lines 0 comments Download
M trunk/src/chrome/common/extensions/docs/templates/json/apps_sidenav.json View 11 chunks +39 lines, -39 lines 0 comments Download
M trunk/src/chrome/common/extensions/docs/templates/json/extensions_sidenav.json View 8 chunks +44 lines, -44 lines 0 comments Download
D trunk/src/chrome/common/extensions/docs/templates/json/manifest.json View 1 chunk +0 lines, -176 lines 0 comments Download
M trunk/src/chrome/common/extensions/docs/templates/private/header_body.html View 1 chunk +1 line, -1 line 0 comments Download
D trunk/src/chrome/common/extensions/docs/templates/private/manifest_example.html View 1 chunk +0 lines, -17 lines 0 comments Download
D trunk/src/chrome/common/extensions/docs/templates/private/manifest_properties.html View 1 chunk +0 lines, -6 lines 0 comments Download
M trunk/src/chrome/common/extensions/docs/templates/private/sidenav_item.html View 1 chunk +4 lines, -4 lines 0 comments Download
D trunk/src/chrome/common/extensions/docs/templates/public/apps/browserAction.html View 1 chunk +0 lines, -1 line 0 comments Download
D trunk/src/chrome/common/extensions/docs/templates/public/apps/fileBrowserHandler.html View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/chrome/common/extensions/docs/templates/public/apps/manifest.html View 1 chunk +1 line, -1 line 0 comments Download
D trunk/src/chrome/common/extensions/docs/templates/public/apps/manifest/app.html View 1 chunk +0 lines, -1 line 0 comments Download
D trunk/src/chrome/common/extensions/docs/templates/public/apps/manifest/default_locale.html View 1 chunk +0 lines, -1 line 0 comments Download
D trunk/src/chrome/common/extensions/docs/templates/public/apps/manifest/description.html View 1 chunk +0 lines, -1 line 0 comments Download
D trunk/src/chrome/common/extensions/docs/templates/public/apps/manifest/file_handlers.html View 1 chunk +0 lines, -1 line 0 comments Download
D trunk/src/chrome/common/extensions/docs/templates/public/apps/manifest/homepage_url.html View 1 chunk +0 lines, -1 line 0 comments Download
D trunk/src/chrome/common/extensions/docs/templates/public/apps/manifest/icons.html View 1 chunk +0 lines, -1 line 0 comments Download
D trunk/src/chrome/common/extensions/docs/templates/public/apps/manifest/incognito.html View 1 chunk +0 lines, -1 line 0 comments Download
D trunk/src/chrome/common/extensions/docs/templates/public/apps/manifest/key.html View 1 chunk +0 lines, -1 line 0 comments Download
D trunk/src/chrome/common/extensions/docs/templates/public/apps/manifest/kiosk_enabled.html View 1 chunk +0 lines, -1 line 0 comments Download
D trunk/src/chrome/common/extensions/docs/templates/public/apps/manifest/manifest_version.html View 1 chunk +0 lines, -1 line 0 comments Download
D trunk/src/chrome/common/extensions/docs/templates/public/apps/manifest/minimum_chrome_version.html View 1 chunk +0 lines, -1 line 0 comments Download
D trunk/src/chrome/common/extensions/docs/templates/public/apps/manifest/nacl_modules.html View 1 chunk +0 lines, -1 line 0 comments Download
D trunk/src/chrome/common/extensions/docs/templates/public/apps/manifest/name.html View 1 chunk +0 lines, -1 line 0 comments Download
D trunk/src/chrome/common/extensions/docs/templates/public/apps/manifest/offline_enabled.html View 1 chunk +0 lines, -1 line 0 comments Download
D trunk/src/chrome/common/extensions/docs/templates/public/apps/manifest/requirements.html View 1 chunk +0 lines, -1 line 0 comments Download
D trunk/src/chrome/common/extensions/docs/templates/public/apps/manifest/sandbox.html View 1 chunk +0 lines, -1 line 0 comments Download
D trunk/src/chrome/common/extensions/docs/templates/public/apps/manifest/version.html View 1 chunk +0 lines, -1 line 0 comments Download
D trunk/src/chrome/common/extensions/docs/templates/public/apps/manifest/web_accessible_resources.html View 1 chunk +0 lines, -1 line 0 comments Download
D trunk/src/chrome/common/extensions/docs/templates/public/apps/omnibox.html View 1 chunk +0 lines, -1 line 0 comments Download
D trunk/src/chrome/common/extensions/docs/templates/public/apps/pageAction.html View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/chrome/common/extensions/docs/templates/public/extensions/manifest.html View 1 chunk +1 line, -1 line 0 comments Download
D trunk/src/chrome/common/extensions/docs/templates/public/extensions/manifest/default_locale.html View 1 chunk +0 lines, -1 line 0 comments Download
D trunk/src/chrome/common/extensions/docs/templates/public/extensions/manifest/description.html View 1 chunk +0 lines, -1 line 0 comments Download
D trunk/src/chrome/common/extensions/docs/templates/public/extensions/manifest/file_handlers.html View 1 chunk +0 lines, -1 line 0 comments Download
D trunk/src/chrome/common/extensions/docs/templates/public/extensions/manifest/homepage_url.html View 1 chunk +0 lines, -1 line 0 comments Download
D trunk/src/chrome/common/extensions/docs/templates/public/extensions/manifest/icons.html View 1 chunk +0 lines, -1 line 0 comments Download
D trunk/src/chrome/common/extensions/docs/templates/public/extensions/manifest/incognito.html View 1 chunk +0 lines, -1 line 0 comments Download
D trunk/src/chrome/common/extensions/docs/templates/public/extensions/manifest/key.html View 1 chunk +0 lines, -1 line 0 comments Download
D trunk/src/chrome/common/extensions/docs/templates/public/extensions/manifest/kiosk_enabled.html View 1 chunk +0 lines, -1 line 0 comments Download
D trunk/src/chrome/common/extensions/docs/templates/public/extensions/manifest/manifest_version.html View 1 chunk +0 lines, -1 line 0 comments Download
D trunk/src/chrome/common/extensions/docs/templates/public/extensions/manifest/minimum_chrome_version.html View 1 chunk +0 lines, -1 line 0 comments Download
D trunk/src/chrome/common/extensions/docs/templates/public/extensions/manifest/nacl_modules.html View 1 chunk +0 lines, -1 line 0 comments Download
D trunk/src/chrome/common/extensions/docs/templates/public/extensions/manifest/name.html View 1 chunk +0 lines, -1 line 0 comments Download
D trunk/src/chrome/common/extensions/docs/templates/public/extensions/manifest/offline_enabled.html View 1 chunk +0 lines, -1 line 0 comments Download
D trunk/src/chrome/common/extensions/docs/templates/public/extensions/manifest/requirements.html View 1 chunk +0 lines, -1 line 0 comments Download
D trunk/src/chrome/common/extensions/docs/templates/public/extensions/manifest/sandbox.html View 1 chunk +0 lines, -1 line 0 comments Download
D trunk/src/chrome/common/extensions/docs/templates/public/extensions/manifest/version.html View 1 chunk +0 lines, -1 line 0 comments Download
D trunk/src/chrome/common/extensions/docs/templates/public/extensions/manifest/web_accessible_resources.html View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
not at google - send to devlin
7 years, 7 months ago (2013-05-12 04:21:41 UTC) #1
not at google - send to devlin
7 years, 7 months ago (2013-05-12 04:37:17 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 manually as r199634.

Powered by Google App Engine
This is Rietveld 408576698