Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 1471193002: X87: [builtins] Sanitize the machinery around Construct calls. (Closed)

Created:
5 years ago by zhengxing.li
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [builtins] Sanitize the machinery around Construct calls. port 374b6ea210f0ce669cdec3bafd4a72dbba5fe2ad (r32172) original commit message: There's no point in collecting feedback for super constructor calls, because in all (interesting) cases we can gather (better) feedback from other sources (i.e. via inlining or via using a LOAD_IC to get to the [[Prototype]] of the target). So CallConstructStub is now only used for new Foo(...args) sites where we want to collect feedback in the baseline compiler. The optimizing compilers, Reflect.construct and super constructor calls use the Construct builtin directly, which allows us to remove some weird code from the CallConstructStub (and opens the possibility for more code sharing with the CallICStub, maybe even going for a ConstructICStub). Also remove the 100% redundant HCallNew instruction, which is just a wrapper for the Construct builtin anyway (indirectly via the CallConstructStub). Drive-by-fix: Drop unused has_function_cache bit on Code objects. BUG= Committed: https://crrev.com/4620a235bfcf7a016325f5640568da194df85be7 Cr-Commit-Position: refs/heads/master@{#32197}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -113 lines) Patch
M src/crankshaft/x87/lithium-codegen-x87.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M src/crankshaft/x87/lithium-x87.h View 2 chunks +0 lines, -20 lines 0 comments Download
M src/crankshaft/x87/lithium-x87.cc View 2 chunks +0 lines, -17 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 2 chunks +4 lines, -9 lines 0 comments Download
M src/x87/builtins-x87.cc View 2 chunks +9 lines, -8 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 7 chunks +17 lines, -46 lines 0 comments Download
M src/x87/interface-descriptors-x87.cc View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
zhengxing.li
5 years ago (2015-11-24 03:22:43 UTC) #2
Weiliang
lgtm
5 years ago (2015-11-24 03:26:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1471193002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1471193002/1
5 years ago (2015-11-24 03:27:07 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_mac_rel on tryserver.v8 (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/12183)
5 years ago (2015-11-24 09:27:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1471193002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1471193002/1
5 years ago (2015-11-24 09:29:24 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-24 09:53:39 UTC) #10
commit-bot: I haz the power
5 years ago (2015-11-24 09:53:54 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4620a235bfcf7a016325f5640568da194df85be7
Cr-Commit-Position: refs/heads/master@{#32197}

Powered by Google App Engine
This is Rietveld 408576698