pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart - Issue 1471173003: hook new DartCompletionContributor API into existing framework

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart

Issue 1471173003: hook new DartCompletionContributor API into existing framework (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: merge Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/test/services/completion/dart/common_usage_sorter_test.dart ('k') | pkg/analysis_server/test/services/completion/dart/keyword_contributor_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart

diff --git a/pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart b/pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart

index a8db9430065b421aa07b9f862f54dfc115e4c719..91ebc1b92c37ebb092bb6b8fc268c03c7bc171cb 100644

--- a/pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart

+++ b/pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart

@@ -11,10 +11,9 @@ import 'package:analysis_server/plugin/protocol/protocol.dart' as protocol

import 'package:analysis_server/plugin/protocol/protocol.dart'

hide Element, ElementKind;

import 'package:analysis_server/plugin/protocol/protocol.dart';

-import 'package:analysis_server/src/provisional/completion/completion_core.dart'

- show AnalysisRequest, CompletionContributor, CompletionRequest;

import 'package:analysis_server/src/provisional/completion/completion_dart.dart';

-import 'package:analysis_server/src/services/completion/completion_dart.dart'

+import 'package:analysis_server/src/services/completion/completion_core.dart';

+import 'package:analysis_server/src/services/completion/dart/completion_manager.dart'

show DartCompletionRequestImpl;

import 'package:analysis_server/src/services/completion/dart_completion_manager.dart'

show DART_RELEVANCE_DEFAULT, DART_RELEVANCE_LOW;

@@ -25,7 +24,6 @@ import 'package:analyzer/src/generated/source.dart';

import 'package:unittest/unittest.dart';

import '../../../abstract_context.dart';

-import 'package:analysis_server/src/services/completion/completion_core.dart';

int suggestionComparator(CompletionSuggestion s1, CompletionSuggestion s2) {

String c1 = s1.completion.toLowerCase();

@@ -40,7 +38,7 @@ abstract class DartCompletionContributorTest extends AbstractContextTest {

Source testSource;

int completionOffset;

DartCompletionContributor contributor;

- CompletionRequest request;

+ DartCompletionRequest request;

List<CompletionSuggestion> suggestions;

void addTestSource(String content) {