pkg/analysis_server/test/services/completion/completion_test_util.dart - Issue 1471173003: hook new DartCompletionContributor API into existing framework

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/test/services/completion/completion_test_util.dart

Issue 1471173003: hook new DartCompletionContributor API into existing framework (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: merge Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/test/services/completion/completion_computer_test.dart ('k') | pkg/analysis_server/test/services/completion/dart/common_usage_sorter_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/test/services/completion/completion_test_util.dart

diff --git a/pkg/analysis_server/test/services/completion/completion_test_util.dart b/pkg/analysis_server/test/services/completion/completion_test_util.dart

index 0736615b5b94ed383fb3c2071de2b427a64403e0..68d19587c0c9bd24277a33278ee69d80fce019a7 100644

--- a/pkg/analysis_server/test/services/completion/completion_test_util.dart

+++ b/pkg/analysis_server/test/services/completion/completion_test_util.dart

@@ -441,7 +441,7 @@ abstract class AbstractCompletionTest extends AbstractContextTest {

bool computeFast() {

expect(computeFastResult, isNull);

_completionManager = new DartCompletionManager(context, searchEngine,

- testSource, cache, [contributor], new CommonUsageSorter({}));

+ testSource, cache, [contributor], [], new CommonUsageSorter({}));

var result =

_completionManager.computeFast(request, new CompletionPerformance());

expect(request.replacementOffset, isNotNull);