Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1015)

Issue 1471173003: hook new DartCompletionContributor API into existing framework (Closed)

Created:
5 years, 1 month ago by danrubel
Modified:
5 years ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

hook new DartCompletionContributor API into existing framework and convert KeywordContributor to use new DartCompletionContributor API R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/b9ad8a15e45b0d0c7c78ec11b10e838ac92dbb58

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+492 lines, -2473 lines) Patch
M pkg/analysis_server/lib/src/provisional/completion/completion_dart.dart View 1 chunk +20 lines, -0 lines 0 comments Download
D pkg/analysis_server/lib/src/services/completion/completion_dart.dart View 1 chunk +0 lines, -100 lines 0 comments Download
A + pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart View 2 chunks +38 lines, -2 lines 0 comments Download
A + pkg/analysis_server/lib/src/services/completion/dart/keyword_contributor.dart View 4 chunks +13 lines, -13 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart View 9 chunks +66 lines, -37 lines 0 comments Download
D pkg/analysis_server/lib/src/services/completion/keyword_contributor.dart View 1 chunk +0 lines, -525 lines 0 comments Download
M pkg/analysis_server/test/services/completion/completion_computer_test.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/services/completion/completion_test_util.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/completion/dart/common_usage_sorter_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart View 3 chunks +3 lines, -5 lines 0 comments Download
A + pkg/analysis_server/test/services/completion/dart/keyword_contributor_test.dart View 10 chunks +344 lines, -362 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/test_all.dart View 2 chunks +4 lines, -2 lines 0 comments Download
D pkg/analysis_server/test/services/completion/keyword_contributor_test.dart View 1 chunk +0 lines, -1424 lines 0 comments Download
M pkg/analysis_server/test/services/completion/test_all.dart View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
danrubel
5 years, 1 month ago (2015-11-24 02:50:34 UTC) #2
scheglov
LGTM
5 years ago (2015-11-24 16:02:46 UTC) #3
danrubel
5 years ago (2015-11-24 17:03:48 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
b9ad8a15e45b0d0c7c78ec11b10e838ac92dbb58 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698