[Sync] Add histograms for sync response/error codes

[Sync] Add histograms for sync response/error codes

Also fixes up the GCM error code logging (using the wrong enum that relied on
positive net error codes, while GCM was sending negative)

BUG=556773
Committed: https://crrev.com/e5951cf2ff7c4ef619974ace6c7da25b2376a09d
Cr-Commit-Position: refs/heads/master@{#361360}

[Nicolas Zea, 2015-11-23 22:56:36]

zea@chromium.org changed reviewers:
+ rkaplow@chromium.org

[Nicolas Zea, 2015-11-23 22:56:36]

+Robert, PTAL

[rkaplow, 2015-11-23 23:30:34]

Looking at these enums they don't look compatible, for ex. NetErrorCodes has 0
as OK, combined has 200 as OK.

Is this correct?

[Nicolas Zea, 2015-11-23 23:35:00]

On 2015/11/23 23:30:34, rkaplow wrote:
> Looking at these enums they don't look compatible, for ex. NetErrorCodes has 0
> as OK, combined has 200 as OK.
> 
> Is this correct?

NetErrorCodes, with the exception of OK, are all negative. Http Response Codes
are all positive. As such, as long as the response code is used whenever there's
no error, this should be fine. the GetStatus().is_success() check controls that.
The GCM histograms only record errors anyways. So for both sets of histograms
NetError::OK is never actually recorded.

[rkaplow, 2015-11-23 23:44:00]

lgtm

lgtm - probably worth noting in the description the enum was incorrect because
of the positive/negative flip as well

[Nicolas Zea, 2015-11-23 23:44:46]

Description was changed from

==========
[Sync] Add histograms for sync response/error codes

Also fixes up the GCM error code logging (using the wrong enum)

BUG=556773
==========

to

==========
[Sync] Add histograms for sync response/error codes

Also fixes up the GCM error code logging (using the wrong enum that relied on
positive net error codes, not negative)

BUG=556773
==========

[Nicolas Zea, 2015-11-23 23:45:26]

Description was changed from

==========
[Sync] Add histograms for sync response/error codes

Also fixes up the GCM error code logging (using the wrong enum that relied on
positive net error codes, not negative)

BUG=556773
==========

to

==========
[Sync] Add histograms for sync response/error codes

Also fixes up the GCM error code logging (using the wrong enum that relied on
positive net error codes, while GCM was sending negative)

BUG=556773
==========

[Nicolas Zea, 2015-11-23 23:45:43]

On 2015/11/23 23:44:00, rkaplow wrote:
> lgtm
> 
> lgtm - probably worth noting in the description the enum was incorrect because
> of the positive/negative flip as well

Done

[Nicolas Zea, 2015-11-23 23:45:54]

The CQ bit was checked by zea@chromium.org

[commit-bot: I haz the power, 2015-11-23 23:46:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1471103002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1471103002/40001

[commit-bot: I haz the power, 2015-11-24 02:48:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-24 02:48:54]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Nicolas Zea, 2015-11-24 04:53:16]

The CQ bit was checked by zea@chromium.org

[commit-bot: I haz the power, 2015-11-24 04:54:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1471103002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1471103002/40001

[commit-bot: I haz the power, 2015-11-24 06:36:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-24 06:36:58]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Nicolas Zea, 2015-11-24 16:01:09]

The CQ bit was checked by zea@chromium.org

[commit-bot: I haz the power, 2015-11-24 16:05:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1471103002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1471103002/40001

[commit-bot: I haz the power, 2015-11-24 16:35:57]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-11-24 16:36:58]

Patchset 3 (id:??) landed as
https://crrev.com/e5951cf2ff7c4ef619974ace6c7da25b2376a09d
Cr-Commit-Position: refs/heads/master@{#361360}