Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(700)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1471083002: Add debug option to clip each GrBatch to its device bounds (Closed)

Created:
5 years, 1 month ago by bsalomon
Modified:
5 years ago
Reviewers:
joshualitt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@clipbounds
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add debug option to clip each GrBatch to its device bounds Committed: https://skia.googlesource.com/skia/+/69cfe95b7be386cf7d349b61388e93ea7c3cd386

Patch Set 1 #

Total comments: 1

Patch Set 2 : update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -17 lines) Patch
M dm/DMGpuSupport.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M dm/DMSrcSink.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M include/gpu/GrContext.h View 1 chunk +1 line, -1 line 0 comments Download
M include/gpu/GrContextOptions.h View 2 chunks +6 lines, -1 line 0 comments Download
M src/gpu/GrClipMaskManager.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/gpu/GrClipMaskManager.cpp View 1 3 chunks +42 lines, -3 lines 0 comments Download
M src/gpu/GrContext.cpp View 2 chunks +5 lines, -3 lines 0 comments Download
M src/gpu/GrDrawTarget.h View 1 chunk +7 lines, -3 lines 0 comments Download
M src/gpu/GrDrawTarget.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M src/gpu/GrDrawingManager.h View 2 chunks +3 lines, -1 line 0 comments Download
M src/gpu/GrDrawingManager.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M src/gpu/GrTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 1467253002 Patch 100001

Messages

Total messages: 18 (7 generated)
bsalomon
5 years, 1 month ago (2015-11-23 20:41:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1471083002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1471083002/1
5 years, 1 month ago (2015-11-23 20:41:52 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 1 month ago (2015-11-23 20:41:52 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot/builds/4378) Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia (JOB_FAILED, ...
5 years, 1 month ago (2015-11-23 20:42:48 UTC) #7
joshualitt
https://codereview.chromium.org/1471083002/diff/1/src/gpu/GrClipMaskManager.cpp File src/gpu/GrClipMaskManager.cpp (right): https://codereview.chromium.org/1471083002/diff/1/src/gpu/GrClipMaskManager.cpp#newcode296 src/gpu/GrClipMaskManager.cpp:296: SkIRect intersect; braces
5 years, 1 month ago (2015-11-23 20:48:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1471083002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1471083002/20001
5 years, 1 month ago (2015-11-23 21:05:59 UTC) #10
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Please ask for an LGTM from a full ...
5 years, 1 month ago (2015-11-24 02:41:05 UTC) #12
bsalomon
ping
5 years ago (2015-11-30 16:16:32 UTC) #13
joshualitt
On 2015/11/30 16:16:32, bsalomon wrote: > ping lgtm
5 years ago (2015-11-30 16:21:10 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1471083002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1471083002/20001
5 years ago (2015-11-30 21:14:42 UTC) #16
commit-bot: I haz the power
5 years ago (2015-11-30 21:27:50 UTC) #18
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/69cfe95b7be386cf7d349b61388e93ea7c3cd386

Powered by Google App Engine
This is Rietveld 408576698