Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Issue 1471073011: Add README in tools/drmemory for using Dr. Memory (Closed)

Created:
5 years ago by zhaoqin1
Modified:
5 years ago
Reviewers:
Tom Sepez, zhaoqin
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add README in tools/drmemory for using Dr. Memory R=tsepez@chromium.org BUG=PDFium:238 Committed: https://pdfium.googlesource.com/pdfium/+/7e413d168beba325078aa4b484729ad22919a2c3

Patch Set 1 #

Total comments: 2

Patch Set 2 : add Windows Only #

Total comments: 1

Patch Set 3 : fina #

Patch Set 4 : remove trailing space #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -0 lines) Patch
A tools/drmemory/README View 1 2 3 1 chunk +86 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
zhaoqin1
5 years ago (2015-11-25 21:33:11 UTC) #1
Tom Sepez
https://codereview.chromium.org/1471073011/diff/1/tools/drmemory/README File tools/drmemory/README (right): https://codereview.chromium.org/1471073011/diff/1/tools/drmemory/README#newcode42 tools/drmemory/README:42: ### Run your application with Dr. Memory Are the ...
5 years ago (2015-11-25 21:45:01 UTC) #2
zhaoqin
https://codereview.chromium.org/1471073011/diff/1/tools/drmemory/README File tools/drmemory/README (right): https://codereview.chromium.org/1471073011/diff/1/tools/drmemory/README#newcode42 tools/drmemory/README:42: ### Run your application with Dr. Memory On 2015/11/25 ...
5 years ago (2015-11-25 21:50:44 UTC) #4
Tom Sepez
lgtm https://codereview.chromium.org/1471073011/diff/20001/tools/drmemory/README File tools/drmemory/README (right): https://codereview.chromium.org/1471073011/diff/20001/tools/drmemory/README#newcode10 tools/drmemory/README:10: Windows, Linux, or Mac on commodity IA-32 and ...
5 years ago (2015-11-26 00:03:27 UTC) #5
zhaoqin1
5 years ago (2015-11-30 19:50:15 UTC) #7
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
7e413d168beba325078aa4b484729ad22919a2c3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698