chrome/browser/download/download_browsertest.cc - Issue 1471073008: Do not do unnecessary recursive deletes for files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/download_browsertest.cc

Issue 1471073008: Do not do unnecessary recursive deletes for files. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/download/download_browsertest.cc

diff --git a/chrome/browser/download/download_browsertest.cc b/chrome/browser/download/download_browsertest.cc

index 4d48d787a0e64ce9e9e6f8b15037de2aaeb41acb..7b0e9beaafed872e74f89a3efe0730cb4fdcc365 100644

--- a/chrome/browser/download/download_browsertest.cc

+++ b/chrome/browser/download/download_browsertest.cc

@@ -793,7 +793,7 @@ class DownloadTest : public InProcessBrowserTest {

EXPECT_TRUE(VerifyFile(download_path, expected_contents, file_size));

// Delete the file we just downloaded.

- EXPECT_TRUE(base::DieFileDie(download_path, true));

+ EXPECT_TRUE(base::DieFileDie(download_path, false));

EXPECT_FALSE(base::PathExists(download_path));

return true;