Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2652)

Unified Diff: base/metrics/sparse_histogram.cc

Issue 1471073007: Reorganize histograms for persistence. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@shmem-alloc
Patch Set: added GN changes Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/metrics/sparse_histogram.cc
diff --git a/base/metrics/sparse_histogram.cc b/base/metrics/sparse_histogram.cc
index 39c276d7877290a9a93123b728061cb06099c51b..8e8e774cd3ee5957548ac44b5e5c91d2162efcd6 100644
--- a/base/metrics/sparse_histogram.cc
+++ b/base/metrics/sparse_histogram.cc
@@ -4,6 +4,7 @@
#include "base/metrics/sparse_histogram.h"
+#include "base/metrics/metrics_hashes.h"
#include "base/metrics/sample_map.h"
#include "base/metrics/statistics_recorder.h"
#include "base/pickle.h"
@@ -33,6 +34,10 @@ HistogramBase* SparseHistogram::FactoryGet(const std::string& name,
SparseHistogram::~SparseHistogram() {}
+uint64_t SparseHistogram::id() const {
+ return samples_.id();
+}
+
HistogramType SparseHistogram::GetHistogramType() const {
return SPARSE_HISTOGRAM;
}
@@ -63,7 +68,8 @@ void SparseHistogram::AddCount(Sample value, int count) {
}
scoped_ptr<HistogramSamples> SparseHistogram::SnapshotSamples() const {
- scoped_ptr<SampleMap> snapshot(new SampleMap());
+ scoped_ptr<SampleMap> snapshot(
+ new SampleMap(metrics::HashMetricName(histogram_name())));
base::AutoLock auto_lock(lock_);
snapshot->Add(samples_);
@@ -95,7 +101,8 @@ bool SparseHistogram::SerializeInfoImpl(Pickle* pickle) const {
}
SparseHistogram::SparseHistogram(const std::string& name)
- : HistogramBase(name) {}
+ : HistogramBase(name),
+ samples_(metrics::HashMetricName(name)) {}
HistogramBase* SparseHistogram::DeserializeInfoImpl(PickleIterator* iter) {
std::string histogram_name;

Powered by Google App Engine
This is Rietveld 408576698