base/metrics/histogram_base.h - Issue 1471073007: Reorganize histograms for persistence.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/metrics/histogram_base.h

Issue 1471073007: Reorganize histograms for persistence. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@shmem-alloc

Patch Set: added GN changes Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/metrics/histogram_base.h

diff --git a/base/metrics/histogram_base.h b/base/metrics/histogram_base.h

index d246691ca257093851f7dc7c6393d7af51a3285b..271df981591cc24fd0b0fd695eb27bc844798d0d 100644

--- a/base/metrics/histogram_base.h

+++ b/base/metrics/histogram_base.h

@@ -104,6 +104,9 @@ class BASE_EXPORT HistogramBase {

// in more compact machine code being generated by the macros.

void CheckName(const StringPiece& name) const;

+ // Get a unique ID for this histogram's samples.

+ virtual uint64_t id() const = 0;

Alexei Svitkine (slow) 2015/11/25 18:05:27 I think it's better to be explicit about what this

bcwhite 2015/11/25 21:54:17 Done.

// Operations with Flags enum.

int32_t flags() const { return subtle::NoBarrier_Load(&flags_); }

void SetFlags(int32_t flags);