components/metrics/metrics_log_unittest.cc - Issue 1471073007: Reorganize histograms for persistence.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/metrics/metrics_log_unittest.cc

Issue 1471073007: Reorganize histograms for persistence. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@shmem-alloc

Patch Set: addressed review comments by Alexei Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/metrics/metrics_log_unittest.cc

diff --git a/components/metrics/metrics_log_unittest.cc b/components/metrics/metrics_log_unittest.cc

index 10663b302dea46272fd347ec67f58096579539d7..bbdbbe5dec29dfc6029210b75ec7c48bfdd94213 100644

--- a/components/metrics/metrics_log_unittest.cc

+++ b/components/metrics/metrics_log_unittest.cc

@@ -192,7 +192,7 @@ TEST_F(MetricsLogTest, HistogramBucketFields) {

ranges.set_range(6, 11);

ranges.set_range(7, 12);

- base::SampleVector samples(&ranges);

+ base::SampleVector samples(1, &ranges);

samples.Accumulate(3, 1); // Bucket 1-5.

samples.Accumulate(6, 1); // Bucket 5-7.

samples.Accumulate(8, 1); // Bucket 8-9. (7-8 skipped)

« no previous file with comments | « components/metrics/histogram_encoder_unittest.cc ('k') | no next file » | no next file with comments »