Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Unified Diff: base/metrics/histogram_snapshot_manager.h

Issue 1471073007: Reorganize histograms for persistence. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@shmem-alloc
Patch Set: addressed review comments by Alexei Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/metrics/histogram_samples.cc ('k') | base/metrics/histogram_snapshot_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/metrics/histogram_snapshot_manager.h
diff --git a/base/metrics/histogram_snapshot_manager.h b/base/metrics/histogram_snapshot_manager.h
index 5a5f2e93e5e88b28c0e3898198cf2ae646f636c6..867049fd634c3f2168cfc64bd3414a3546d5e581 100644
--- a/base/metrics/histogram_snapshot_manager.h
+++ b/base/metrics/histogram_snapshot_manager.h
@@ -48,10 +48,12 @@ class BASE_EXPORT HistogramSnapshotManager {
// For histograms, track what we've already recorded (as a sample for
// each histogram) so that we can record only the delta with the next log.
- std::map<std::string, HistogramSamples*> logged_samples_;
+ // The information is indexed by the hash of the histogram name.
+ std::map<uint64_t, HistogramSamples*> logged_samples_;
- // List of histograms found to be corrupt, and their problems.
- std::map<std::string, int> inconsistencies_;
+ // Set of histograms found to be corrupt and their problems, indexed
+ // by the hash of the histogram name.
+ std::map<uint64_t, int> inconsistencies_;
// |histogram_flattener_| handles the logistics of recording the histogram
// deltas.
« no previous file with comments | « base/metrics/histogram_samples.cc ('k') | base/metrics/histogram_snapshot_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698