Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Side by Side Diff: base/metrics/sample_vector.h

Issue 1471073007: Reorganize histograms for persistence. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@shmem-alloc
Patch Set: added GN changes Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // SampleVector implements HistogramSamples interface. It is used by all 5 // SampleVector implements HistogramSamples interface. It is used by all
6 // Histogram based classes to store samples. 6 // Histogram based classes to store samples.
7 7
8 #ifndef BASE_METRICS_SAMPLE_VECTOR_H_ 8 #ifndef BASE_METRICS_SAMPLE_VECTOR_H_
9 #define BASE_METRICS_SAMPLE_VECTOR_H_ 9 #define BASE_METRICS_SAMPLE_VECTOR_H_
10 10
11 #include <vector> 11 #include <vector>
12 12
13 #include "base/compiler_specific.h" 13 #include "base/compiler_specific.h"
14 #include "base/gtest_prod_util.h" 14 #include "base/gtest_prod_util.h"
15 #include "base/memory/scoped_ptr.h" 15 #include "base/memory/scoped_ptr.h"
16 #include "base/metrics/histogram_base.h" 16 #include "base/metrics/histogram_base.h"
17 #include "base/metrics/histogram_samples.h" 17 #include "base/metrics/histogram_samples.h"
18 18
19 namespace base { 19 namespace base {
20 20
21 class BucketRanges; 21 class BucketRanges;
22 22
23 class BASE_EXPORT SampleVector : public HistogramSamples { 23 class BASE_EXPORT SampleVector : public HistogramSamples {
24 public: 24 public:
25 explicit SampleVector(const BucketRanges* bucket_ranges); 25 SampleVector(uint64 id, const BucketRanges* bucket_ranges);
26 SampleVector(uint64 id,
27 HistogramBase::AtomicCount* counts,
28 size_t counts_size,
29 Metadata* meta,
30 const BucketRanges* bucket_ranges);
26 ~SampleVector() override; 31 ~SampleVector() override;
27 32
28 // HistogramSamples implementation: 33 // HistogramSamples implementation:
29 void Accumulate(HistogramBase::Sample value, 34 void Accumulate(HistogramBase::Sample value,
30 HistogramBase::Count count) override; 35 HistogramBase::Count count) override;
31 HistogramBase::Count GetCount(HistogramBase::Sample value) const override; 36 HistogramBase::Count GetCount(HistogramBase::Sample value) const override;
32 HistogramBase::Count TotalCount() const override; 37 HistogramBase::Count TotalCount() const override;
33 scoped_ptr<SampleCountIterator> Iterator() const override; 38 scoped_ptr<SampleCountIterator> Iterator() const override;
34 39
35 // Get count of a specific bucket. 40 // Get count of a specific bucket.
36 HistogramBase::Count GetCountAtIndex(size_t bucket_index) const; 41 HistogramBase::Count GetCountAtIndex(size_t bucket_index) const;
37 42
38 protected: 43 protected:
39 bool AddSubtractImpl( 44 bool AddSubtractImpl(
40 SampleCountIterator* iter, 45 SampleCountIterator* iter,
41 HistogramSamples::Operator op) override; // |op| is ADD or SUBTRACT. 46 HistogramSamples::Operator op) override; // |op| is ADD or SUBTRACT.
42 47
43 virtual size_t GetBucketIndex(HistogramBase::Sample value) const; 48 virtual size_t GetBucketIndex(HistogramBase::Sample value) const;
44 49
45 private: 50 private:
46 FRIEND_TEST_ALL_PREFIXES(HistogramTest, CorruptSampleCounts); 51 FRIEND_TEST_ALL_PREFIXES(HistogramTest, CorruptSampleCounts);
47 52
48 std::vector<HistogramBase::AtomicCount> counts_; 53 // In the case where this class manages the memory, here it is.
54 std::vector<HistogramBase::AtomicCount> local_counts_;
55
56 // These are raw pointers rather than objects for flexibility. The actual
57 // memory is either managed by local_counts_ above or by an external object
58 // and passed in directly.
59 HistogramBase::AtomicCount* counts_;
60 size_t counts_size_;
49 61
50 // Shares the same BucketRanges with Histogram object. 62 // Shares the same BucketRanges with Histogram object.
51 const BucketRanges* const bucket_ranges_; 63 const BucketRanges* const bucket_ranges_;
52 64
53 DISALLOW_COPY_AND_ASSIGN(SampleVector); 65 DISALLOW_COPY_AND_ASSIGN(SampleVector);
54 }; 66 };
55 67
56 class BASE_EXPORT SampleVectorIterator : public SampleCountIterator { 68 class BASE_EXPORT SampleVectorIterator : public SampleCountIterator {
57 public: 69 public:
58 SampleVectorIterator(const std::vector<HistogramBase::AtomicCount>* counts, 70 SampleVectorIterator(const std::vector<HistogramBase::AtomicCount>* counts,
59 const BucketRanges* bucket_ranges); 71 const BucketRanges* bucket_ranges);
72 SampleVectorIterator(const HistogramBase::AtomicCount* counts,
73 size_t counts_size,
74 const BucketRanges* bucket_ranges);
60 ~SampleVectorIterator() override; 75 ~SampleVectorIterator() override;
61 76
62 // SampleCountIterator implementation: 77 // SampleCountIterator implementation:
63 bool Done() const override; 78 bool Done() const override;
64 void Next() override; 79 void Next() override;
65 void Get(HistogramBase::Sample* min, 80 void Get(HistogramBase::Sample* min,
66 HistogramBase::Sample* max, 81 HistogramBase::Sample* max,
67 HistogramBase::Count* count) const override; 82 HistogramBase::Count* count) const override;
68 83
69 // SampleVector uses predefined buckets, so iterator can return bucket index. 84 // SampleVector uses predefined buckets, so iterator can return bucket index.
70 bool GetBucketIndex(size_t* index) const override; 85 bool GetBucketIndex(size_t* index) const override;
71 86
72 private: 87 private:
73 void SkipEmptyBuckets(); 88 void SkipEmptyBuckets();
74 89
75 const std::vector<HistogramBase::AtomicCount>* counts_; 90 const HistogramBase::AtomicCount* counts_;
91 size_t counts_size_;
76 const BucketRanges* bucket_ranges_; 92 const BucketRanges* bucket_ranges_;
77 93
78 size_t index_; 94 size_t index_;
79 }; 95 };
80 96
81 } // namespace base 97 } // namespace base
82 98
83 #endif // BASE_METRICS_SAMPLE_VECTOR_H_ 99 #endif // BASE_METRICS_SAMPLE_VECTOR_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698