Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Unified Diff: src/typing-asm.h

Issue 1471073003: Make typing-asm match spec more closely around load/store, add more tests. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: fix Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/type-cache.h ('k') | src/typing-asm.cc » ('j') | src/typing-asm.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/typing-asm.h
diff --git a/src/typing-asm.h b/src/typing-asm.h
index 5f7a929a1e5bf99e7c8c1d4136ceb3a97e738d49..0834af7b92bdd610f070200fa7f3e5ff8d8d3f12 100644
--- a/src/typing-asm.h
+++ b/src/typing-asm.h
@@ -36,6 +36,7 @@ class AsmTyper : public AstVisitor {
Type* expected_type_;
Type* computed_type_;
int intish_; // How many ops we've gone without a x|0.
+ bool assigning_; // Are we about to assign.
Type* return_type_; // Return type of last function.
size_t array_size_; // Array size of last ArrayLiteral.
@@ -65,7 +66,7 @@ class AsmTyper : public AstVisitor {
void VisitDeclarations(ZoneList<Declaration*>* d) override;
void VisitStatements(ZoneList<Statement*>* s) override;
- void VisitExpressionAnnotation(Expression* e, bool is_return);
+ void VisitExpressionAnnotation(Expression* e, Variable* var, bool is_return);
void VisitFunctionAnnotation(FunctionLiteral* f);
void VisitAsmModule(FunctionLiteral* f);
« no previous file with comments | « src/type-cache.h ('k') | src/typing-asm.cc » ('j') | src/typing-asm.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698