Make typing-asm match spec more closely around load/store, add more tests.

Make typing-asm match spec more closely around load/store, add more tests.

Shifts of integer values are in some contexts collapsed by the parser into single literal AST nodes, rather than a direct representation of the parse tree. Confirming this behavior in tests.

Integer TypedArrays are assumed to load and store "intish" values rather than more fine-grained type information. Reducing the precision of the typing information to match the spec and simplify the wasm generator.

The asm spec requires load and store values of various "float?", "floatish", "double?" and "intish" types to ensure undefined values are not visible and that float32 rounding occurs at the right time. More closely matching this.

Adding additional testing around unsigned / signed comparisons, loads and stores.

Adding addition debug mode printing when asserting about types fail.

BUG= https://code.google.com/p/v8/issues/detail?id=4203
TEST=test-asm-validator, wasm side tests
R=titzer@chromium.org,aseemgarg@chromium.org
LOG=N

Committed: https://crrev.com/cf5546baadc2f15a1a2db638d0a96c0a4137e102
Cr-Commit-Position: refs/heads/master@{#32419}

[bradn, 2015-11-24 05:44:19]

Description was changed from

==========
Correct typing-asm load/store behavior + unsigned.

BUG= https://code.google.com/p/v8/issues/detail?id=4203
TEST=test-asm-validator, wasm side tests
R=titzer@chromium.org,aseemgarg@chromium.org
LOG=N
==========

to

==========
Make typing-asm match spec more closely around load/store, add more tests.

BUG= https://code.google.com/p/v8/issues/detail?id=4203
TEST=test-asm-validator, wasm side tests
R=titzer@chromium.org,aseemgarg@chromium.org
LOG=N
==========

[bradn, 2015-11-24 06:37:14]

Description was changed from

==========
Make typing-asm match spec more closely around load/store, add more tests.

BUG= https://code.google.com/p/v8/issues/detail?id=4203
TEST=test-asm-validator, wasm side tests
R=titzer@chromium.org,aseemgarg@chromium.org
LOG=N
==========

to

==========
Make typing-asm match spec more closely around load/store, add more tests.

Shifts of integer values are in some contexts collapsed by the parser into
single literal AST nodes, rather than a direct representation of the parse tree.
Confirming this behavior in tests.

Integer TypedArrays are assumed to load and store "intish" values rather than
more fine-grained type information. Reducing the precision of the typing
information to match the spec and simplify the wasm generator.

The asm spec requires load and store values of various "float?", "floatish",
"double?" and "intish" types to ensure undefined values are not visible and that
float32 rounding occurs at the right time. More closely matching this.

Adding additional testing around unsigned / signed comparisons, loads and
stores.

Adding addition debug mode printing when asserting about types fail.

BUG= https://code.google.com/p/v8/issues/detail?id=4203
TEST=test-asm-validator, wasm side tests
R=titzer@chromium.org,aseemgarg@chromium.org
LOG=N
==========

[bradn, 2015-11-24 07:03:38]

Patchset #2 (id:20001) has been deleted

[bradn, 2015-11-24 07:03:41]

Patchset #1 (id:1) has been deleted

[titzer, 2015-11-24 07:32:32]

https://codereview.chromium.org/1471073003/diff/40001/src/typing-asm.cc
File src/typing-asm.cc (right):

https://codereview.chromium.org/1471073003/diff/40001/src/typing-asm.cc#newco...
src/typing-asm.cc:613: assigning_ = true;
At first glance this follow a stack discipline, but then I realized that I think
we need to do a pattern match right here in the assignment. E.g. what if there
are nested assignments right in the target?

"foo[bar = x] = y;"

which probably not valid asm.js, but we could get confused and think so when
recursing through the outer assignment.

[bradn, 2015-11-30 20:34:44]

ptal

https://codereview.chromium.org/1471073003/diff/40001/src/typing-asm.cc
File src/typing-asm.cc (right):

https://codereview.chromium.org/1471073003/diff/40001/src/typing-asm.cc#newco...
src/typing-asm.cc:613: assigning_ = true;
On 2015/11/24 07:32:32, titzer wrote:
> At first glance this follow a stack discipline, but then I realized that I
think
> we need to do a pattern match right here in the assignment. E.g. what if there
> are nested assignments right in the target?
> 
> "foo[bar = x] = y;"
> 
> which probably not valid asm.js, but we could get confused and think so when
> recursing through the outer assignment.

So it turns out the spec allows nested assignment, but not like this, but for
instance:
foo[(bar = x) >> 0] = y; etc

The current flag could have worked, if I stashed away the prior state of it
inside each VisitAssignment, but as assignments are limited to either:
identifier = EXPR / heap[..] = EXPR, I've just done that explicitly and made the
flag a parameter.

[titzer, 2015-11-30 20:45:30]

lgtm

[bradn, 2015-11-30 20:45:52]

The CQ bit was checked by bradnelson@google.com

[commit-bot: I haz the power, 2015-11-30 20:45:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1471073003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1471073003/80001

[commit-bot: I haz the power, 2015-11-30 21:11:42]

Description was changed from

==========
Make typing-asm match spec more closely around load/store, add more tests.

Shifts of integer values are in some contexts collapsed by the parser into
single literal AST nodes, rather than a direct representation of the parse tree.
Confirming this behavior in tests.

Integer TypedArrays are assumed to load and store "intish" values rather than
more fine-grained type information. Reducing the precision of the typing
information to match the spec and simplify the wasm generator.

The asm spec requires load and store values of various "float?", "floatish",
"double?" and "intish" types to ensure undefined values are not visible and that
float32 rounding occurs at the right time. More closely matching this.

Adding additional testing around unsigned / signed comparisons, loads and
stores.

Adding addition debug mode printing when asserting about types fail.

BUG= https://code.google.com/p/v8/issues/detail?id=4203
TEST=test-asm-validator, wasm side tests
R=titzer@chromium.org,aseemgarg@chromium.org
LOG=N
==========

to

==========
Make typing-asm match spec more closely around load/store, add more tests.

Shifts of integer values are in some contexts collapsed by the parser into
single literal AST nodes, rather than a direct representation of the parse tree.
Confirming this behavior in tests.

Integer TypedArrays are assumed to load and store "intish" values rather than
more fine-grained type information. Reducing the precision of the typing
information to match the spec and simplify the wasm generator.

The asm spec requires load and store values of various "float?", "floatish",
"double?" and "intish" types to ensure undefined values are not visible and that
float32 rounding occurs at the right time. More closely matching this.

Adding additional testing around unsigned / signed comparisons, loads and
stores.

Adding addition debug mode printing when asserting about types fail.

BUG= https://code.google.com/p/v8/issues/detail?id=4203
TEST=test-asm-validator, wasm side tests
R=titzer@chromium.org,aseemgarg@chromium.org
LOG=N
==========

[commit-bot: I haz the power, 2015-11-30 21:11:42]

Committed patchset #3 (id:80001)

[commit-bot: I haz the power, 2015-11-30 21:11:54]

Description was changed from

==========
Make typing-asm match spec more closely around load/store, add more tests.

Shifts of integer values are in some contexts collapsed by the parser into
single literal AST nodes, rather than a direct representation of the parse tree.
Confirming this behavior in tests.

Integer TypedArrays are assumed to load and store "intish" values rather than
more fine-grained type information. Reducing the precision of the typing
information to match the spec and simplify the wasm generator.

The asm spec requires load and store values of various "float?", "floatish",
"double?" and "intish" types to ensure undefined values are not visible and that
float32 rounding occurs at the right time. More closely matching this.

Adding additional testing around unsigned / signed comparisons, loads and
stores.

Adding addition debug mode printing when asserting about types fail.

BUG= https://code.google.com/p/v8/issues/detail?id=4203
TEST=test-asm-validator, wasm side tests
R=titzer@chromium.org,aseemgarg@chromium.org
LOG=N
==========

to

==========
Make typing-asm match spec more closely around load/store, add more tests.

Shifts of integer values are in some contexts collapsed by the parser into
single literal AST nodes, rather than a direct representation of the parse tree.
Confirming this behavior in tests.

Integer TypedArrays are assumed to load and store "intish" values rather than
more fine-grained type information. Reducing the precision of the typing
information to match the spec and simplify the wasm generator.

The asm spec requires load and store values of various "float?", "floatish",
"double?" and "intish" types to ensure undefined values are not visible and that
float32 rounding occurs at the right time. More closely matching this.

Adding additional testing around unsigned / signed comparisons, loads and
stores.

Adding addition debug mode printing when asserting about types fail.

BUG= https://code.google.com/p/v8/issues/detail?id=4203
TEST=test-asm-validator, wasm side tests
R=titzer@chromium.org,aseemgarg@chromium.org
LOG=N

Committed: https://crrev.com/cf5546baadc2f15a1a2db638d0a96c0a4137e102
Cr-Commit-Position: refs/heads/master@{#32419}
==========

[commit-bot: I haz the power, 2015-11-30 21:11:54]

Patchset 3 (id:??) landed as
https://crrev.com/cf5546baadc2f15a1a2db638d0a96c0a4137e102
Cr-Commit-Position: refs/heads/master@{#32419}