Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 1471073002: Make index provisional API. (Closed)

Created:
5 years, 1 month ago by scheglov
Modified:
5 years, 1 month ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -360 lines) Patch
D pkg/analysis_server/lib/plugin/index/index.dart View 1 chunk +0 lines, -43 lines 0 comments Download
D pkg/analysis_server/lib/plugin/index/index_core.dart View 1 chunk +0 lines, -280 lines 0 comments Download
M pkg/analysis_server/lib/src/plugin/server_plugin.dart View 2 chunks +2 lines, -2 lines 0 comments Download
A + pkg/analysis_server/lib/src/provisional/index/index.dart View 1 chunk +1 line, -1 line 0 comments Download
A + pkg/analysis_server/lib/src/provisional/index/index_core.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
M pkg/analysis_server/lib/src/search/search_domain.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/index/index.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/index/index_contributor.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/index/index_store.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/index/indexable_element.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/index/indexable_file.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/index/local_index.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/index/local_memory_index.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/index/store/codec.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/index/store/split_store.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/search/search_engine_internal.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/index/dart_index_contributor_test.dart View 3 chunks +22 lines, -22 lines 0 comments Download
M pkg/analysis_server/test/services/index/store/codec_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/index/store/split_store_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 1 month ago (2015-11-23 20:25:46 UTC) #1
Brian Wilkerson
LGTM
5 years, 1 month ago (2015-11-23 20:51:52 UTC) #2
scheglov
5 years, 1 month ago (2015-11-23 20:55:01 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0ae251793f2425c463f39e43257267a868a45486 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698