Issue 1471063003: Remove dead functions at link time on Mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1471063003: Remove dead functions at link time on Mac. (Closed)

Created:
5 years ago by rmacnak

Modified:
5 years ago

Reviewers:
Florian Schneider, Ivan Posva

CC:
reviews_dartlang.org, ricow1

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Remove dead functions at link time on Mac. ReleaseX64 stripped dart_precompiled 10.5MB -> 8.4MB (-20%) dart 12.1MB -> 11.5MB (-5%) R=iposva@google.com Committed: https://github.com/dart-lang/sdk/commit/a984188def0b1db80dc4f83ee77bdbde883af5bd

Patch Set 1 #

Created: 5 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	tools/gyp/configurations_xcode.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

rmacnak

Committed patchset #1 (id:1) manually as a984188def0b1db80dc4f83ee77bdbde883af5bd (presubmit successful).

5 years ago (2015-11-23 22:57:44 UTC) #4

Florian Schneider

Lgtm. Is there anythink like gcc/clang's -ffunction-sections for xcode as well, or is it not ...

5 years ago (2015-11-24 10:02:15 UTC) #5

rmacnak

5 years ago (2015-11-24 20:56:16 UTC) #6

Message was sent while issue was closed.

On 2015/11/24 10:02:15, Florian Schneider wrote:
> Lgtm.
> 
> Is there anythink like gcc/clang's -ffunction-sections for xcode as well, or
is
> it not needed?

Xcode complains if given -ffunction-sections. The savings here are about the
same as your change on Linux, so I don't think the compiler needs an extra flag.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages