include/gpu/effects/GrCoverageSetOpXP.h - Issue 1471053002: Don't create a GXPFactory when blend is SrcOver

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: include/gpu/effects/GrCoverageSetOpXP.h

Issue 1471053002: Don't create a GXPFactory when blend is SrcOver (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: nit Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: include/gpu/effects/GrCoverageSetOpXP.h

diff --git a/include/gpu/effects/GrCoverageSetOpXP.h b/include/gpu/effects/GrCoverageSetOpXP.h

index 8511074cbd39cd66690c49dbb101e582fee64a69..a17cf812321a35f4162cff9213b2f5ceb0941753 100644

--- a/include/gpu/effects/GrCoverageSetOpXP.h

+++ b/include/gpu/effects/GrCoverageSetOpXP.h

@@ -23,11 +23,6 @@ class GrCoverageSetOpXPFactory : public GrXPFactory {

public:

static GrXPFactory* Create(SkRegion::Op regionOp, bool invertCoverage = false);

- bool supportsRGBCoverage(GrColor /*knownColor*/,

- uint32_t /*knownColorFlags*/) const override {

- return true;

- }

void getInvariantBlendedColor(const GrProcOptInfo& colorPOI,

GrXPFactory::InvariantBlendedColor*) const override;