gm/texturedomaineffect.cpp - Issue 1471053002: Don't create a GXPFactory when blend is SrcOver

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gm/texturedomaineffect.cpp

Issue 1471053002: Don't create a GXPFactory when blend is SrcOver (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: nit Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gm/texturedomaineffect.cpp

diff --git a/gm/texturedomaineffect.cpp b/gm/texturedomaineffect.cpp

index a2dc4b01b8485023665094da3a3e24b8d912e81b..3eaba9080628fa6cba1490b57fdb66f681e285a6 100644

--- a/gm/texturedomaineffect.cpp

+++ b/gm/texturedomaineffect.cpp

@@ -117,6 +117,8 @@ protected:

for (int m = 0; m < GrTextureDomain::kModeCount; ++m) {

GrTextureDomain::Mode mode = (GrTextureDomain::Mode) m;

GrPipelineBuilder pipelineBuilder;

+ pipelineBuilder.setXPFactory(

+ GrPorterDuffXPFactory::Create(SkXfermode::kSrc_Mode))->unref();

SkAutoTUnref<const GrFragmentProcessor> fp(

GrTextureDomainEffect::Create(texture, textureMatrices[tm],

GrTextureDomain::MakeTexelDomain(texture,