src/gpu/SkGr.cpp - Issue 1471053002: Don't create a GXPFactory when blend is SrcOver

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/gpu/SkGr.cpp

Issue 1471053002: Don't create a GXPFactory when blend is SrcOver (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: fix compile Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/gpu/SkGr.cpp

diff --git a/src/gpu/SkGr.cpp b/src/gpu/SkGr.cpp

index 411b5b2b60322249213f83d322005d460f1202fa..954bb808524243d181ed5066b6d84c5ef7b29449 100644

--- a/src/gpu/SkGr.cpp

+++ b/src/gpu/SkGr.cpp

@@ -489,13 +489,8 @@ static inline bool skpaint_to_grpaint_impl(GrContext* context,

SkXfermode* mode = skPaint.getXfermode();

GrXPFactory* xpFactory = nullptr;

- if (!SkXfermode::AsXPFactory(mode, &xpFactory)) {

- // Fall back to src-over

- // return false here?

- xpFactory = GrPorterDuffXPFactory::Create(SkXfermode::kSrcOver_Mode);

- }

- SkASSERT(xpFactory);

- grPaint->setXPFactory(xpFactory)->unref();

+ SkXfermode::AsXPFactory(mode, &xpFactory);

+ SkSafeUnref(grPaint->setXPFactory(xpFactory));

#ifndef SK_IGNORE_GPU_DITHER

if (skPaint.isDither() && grPaint->numColorFragmentProcessors() > 0) {

« no previous file with comments | « src/gpu/GrYUVProvider.cpp ('k') | src/gpu/batches/GrDefaultPathRenderer.cpp » ('j') | no next file with comments »