Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1471043003: PDF: Remove comment about flaky test which has been fixed (Closed)

Created:
5 years ago by tsergeant
Modified:
5 years ago
Reviewers:
raymes
CC:
chrome-apps-syd-reviews_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

PDF: Remove comment about flaky test which has been fixed BUG=550015 Committed: https://crrev.com/176259e06cb182c941b9179f515af761f68296e2 Cr-Commit-Position: refs/heads/master@{#361278}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M chrome/browser/pdf/pdf_extension_test.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
tsergeant
I'm not sure what the etiquette behind tiny changes like this is, but the flake ...
5 years ago (2015-11-24 04:18:18 UTC) #2
raymes
lgtm
5 years ago (2015-11-24 05:00:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1471043003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1471043003/1
5 years ago (2015-11-24 05:06:13 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/133533)
5 years ago (2015-11-24 06:40:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1471043003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1471043003/1
5 years ago (2015-11-24 06:45:55 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-24 07:55:51 UTC) #10
commit-bot: I haz the power
5 years ago (2015-11-24 07:56:30 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/176259e06cb182c941b9179f515af761f68296e2
Cr-Commit-Position: refs/heads/master@{#361278}

Powered by Google App Engine
This is Rietveld 408576698